linux-kernel - Re: [PATCH 1/3] PCI: tegra: Fix OF node reference leak

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <162816017970.17991.9169417632084960512.b4-ty@arm.com>
Date:   Thu,  5 Aug 2021 11:43:14 +0100
From:   Lorenzo Pieralisi <lorenzo.pieralisi@....com>
To:     bhelgaas@...gle.com,
        Christophe JAILLET <christophe.jaillet@...adoo.fr>,
        jonathanh@...dia.com, thierry.reding@...il.com, robh@...nel.org
Cc:     Lorenzo Pieralisi <lorenzo.pieralisi@....com>,
        linux-tegra@...r.kernel.org, linux-pci@...r.kernel.org,
        kernel-janitors@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/3] PCI: tegra: Fix OF node reference leak

On Tue, 4 May 2021 19:17:42 +0200, Christophe JAILLET wrote:
> Commit 9e38e690ace3 ("PCI: tegra: Fix OF node reference leak") has fixed
> some node reference leaks in this function but missed some of them.
> 
> In fact, having 'port' referenced in the 'rp' structure is not enough to
> prevent the leak, until 'rp' is actually added in the 'pcie->ports' list.
> 
> Add the missing 'goto err_node_put' accordingly.

Applied to pci/tegra, thanks!

[1/3] PCI: tegra: Fix OF node reference leak
      https://git.kernel.org/lpieralisi/pci/c/eff21f5da3
[2/3] PCI: tegra: Use 'seq_puts' instead of 'seq_printf'
      https://git.kernel.org/lpieralisi/pci/c/804b2b6f2a
[3/3] PCI: tegra: make const array err_msg static
      https://git.kernel.org/lpieralisi/pci/c/fd44e8efcc

Thanks,
Lorenzo