linux-kernel - Re: [PATCH 6/6] staging: r8188eu: remove RT_TRACE and DBG_88E prints from xmit

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <YQvFMccB/Gl+AGOf@kroah.com>
Date:   Thu, 5 Aug 2021 13:02:09 +0200
From:   Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:     Martin Kaiser <martin@...ser.cx>
Cc:     Larry Finger <Larry.Finger@...inger.net>,
        Phillip Potter <phil@...lpotter.co.uk>,
        linux-staging@...ts.linux.dev, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 6/6] staging: r8188eu: remove RT_TRACE and DBG_88E prints
 from xmit_linux.c

On Tue, Aug 03, 2021 at 10:15:11PM +0200, Martin Kaiser wrote:
> We should use the standard mechanism for debug prints. Remove the prints
> that use driver-specific macros.

It is ok to remove the RT_TRACE macros, but you are removing the other
debugging calls and are not replacing them with anything.

Are you sure that is ok?  Why not use the proper debugging calls instead
of just deleting them?

thanks,

greg k-h