linux-kernel - Re: [PATCH v7] rtw_security: fix cast to restricted _

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 5 Aug 2021 13:17:47 +0200
From:   Greg KH <gregkh@...uxfoundation.org>
To:     Jhih-Ming Huang <fbihjmeric@...il.com>
Cc:     fabioaiuto83@...il.com, ross.schm.dev@...il.com,
        maqianga@...ontech.com, marcocesati@...il.com,
        linux-staging@...ts.linux.dev, linux-kernel@...r.kernel.org,
        kernel test robot <lkp@...el.com>
Subject: Re: [PATCH v7] rtw_security: fix cast to restricted __le32

On Sun, Aug 01, 2021 at 11:51:52PM +0800, Jhih-Ming Huang wrote:
> This patch fixes the sparse warning of fix cast to restricted __le32.
> 
> There was a change for replacing private CRC-32 routines with in kernel
> ones.
> However, the author used le32_to_cpu to convert crc32_le(), and we
> should use cpu_to_le32.
> 
> Reported-by: kernel test robot <lkp@...el.com>
> Signed-off-by: Jhih-Ming Huang <fbihjmeric@...il.com>
> ---
>  changes from v6:
>    using get_unaligned_le32 to get the value and comparing it with crc,
>    instead of using memcmp with raw pointers.
> 
>  drivers/staging/rtl8723bs/core/rtw_security.c | 12 +++---------
>  1 file changed, 3 insertions(+), 9 deletions(-)

Does not apply to the tree :(