linux-kernel - Re: [PATCH v6 11/14] media: mtk-vcodec: vdec: support stateless H.264 decoding

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CA+Px+wWARA-TF66x3k8nY+TNqNo90Cn2Q_c73a66JUXWkY0dsg@mail.gmail.com>
Date:   Thu, 5 Aug 2021 19:51:34 +0800
From:   Tzung-Bi Shih <tzungbi@...gle.com>
To:     Hans Verkuil <hverkuil-cisco@...all.nl>
Cc:     Alexandre Courbot <acourbot@...omium.org>,
        Tiffany Lin <tiffany.lin@...iatek.com>,
        Andrew-CT Chen <andrew-ct.chen@...iatek.com>,
        Dafna Hirschfeld <dafna.hirschfeld@...labora.com>,
        Yunfei Dong <Yunfei.Dong@...iatek.com>,
        Mauro Carvalho Chehab <mchehab@...nel.org>,
        linux-media@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-mediatek@...ts.infradead.org
Subject: Re: [PATCH v6 11/14] media: mtk-vcodec: vdec: support stateless H.264 decoding

On Tue, Jul 20, 2021 at 6:52 PM Hans Verkuil <hverkuil-cisco@...all.nl> wrote:
> Several new structs do not have any field documentation, but they do start with /**,
> so I get complaints about missing field docs.
>
> After manually changing this to /*, I still get a few remaining warnings:
Will fix in next version.

> mtk-vcodec/vdec/vdec_h264_req_if.c:189: warning: Function parameter or member 'h264_slice_params' not described in 'vdec_h264_vsi'
> mtk-vcodec/vdec/vdec_h264_req_if.c:210: warning: Function parameter or member 'h264_slice_param' not described in 'vdec_h264_slice_inst'
> mtk-vcodec/vdec/vdec_h264_req_if.c:210: warning: Function parameter or member 'dpb' not described in 'vdec_h264_slice_inst'
>
> Can you fix this?
Will fix in next version.

> I also want to take this patch series at the same time:
>
> https://patchwork.linuxtv.org/project/linux-media/cover/20210630085247.27554-1-irui.wang@mediatek.com/
>
> Can you verify that this would not cause any problems with your series? As far as
> I can see it is fine, but a second pair of eyeballs wouldn't hurt.
Series [1] shouldn't cause any problems with this series.

However, series [1] doesn't apply after this series (conflicted with
[2]).  It needs to rebase and send another version after fixing the
typo anyway.

[1]: https://patchwork.linuxtv.org/project/linux-media/cover/20210630085247.27554-1-irui.wang@mediatek.com/
[2]: https://patchwork.linuxtv.org/project/linux-media/patch/20210630085247.27554-3-irui.wang@mediatek.com/