linux-kernel - Re: [PATCH v3 2/7] mfd: tqmx86: clear GPIO IRQ resource when no IRQ is set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHp75VeQxr3pkX9j10wUi3NjZY-Nkn=waPsMDxG=pDprY3Wsyg@mail.gmail.com>
Date:   Thu, 5 Aug 2021 16:42:42 +0300
From:   Andy Shevchenko <andy.shevchenko@...il.com>
To:     Matthias Schiffer <matthias.schiffer@...tq-group.com>
Cc:     Lee Jones <lee.jones@...aro.org>,
        Linus Walleij <linus.walleij@...aro.org>,
        Bartosz Golaszewski <bgolaszewski@...libre.com>,
        Andrew Lunn <andrew@...n.ch>,
        "open list:GPIO SUBSYSTEM" <linux-gpio@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v3 2/7] mfd: tqmx86: clear GPIO IRQ resource when no IRQ
 is set

On Thu, Aug 5, 2021 at 4:40 PM Matthias Schiffer
<matthias.schiffer@...tq-group.com> wrote:
> On Thu, 2021-08-05 at 14:30 +0100, Lee Jones wrote:
> > On Fri, 16 Jul 2021, Matthias Schiffer wrote:

...

> > Strange - why is this !0 in the first place?
>
> I don't see anything strange here. DEFINE_RES_IRQ() sets flags to
> IORESOURCE_IRQ. We reset it to 0 when there is no IRQ to clear that
> resource entry.
>
> An alternative would be to start with an empty entry and only fill in
> the fields when an IRQ is used, but that seems more cumbersome than the
> current code to me.

Another alternative is to start using the IRQ DISABLED resource flag,
but I'm afraid that OF code is not ready for that.
https://elixir.bootlin.com/linux/latest/source/include/linux/ioport.h#L331

-- 
With Best Regards,
Andy Shevchenko