linux-kernel - Re: [PATCH] f2fs: Kconfig: clean up config options about compression

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <23f17a0a-7d0a-97c1-246f-994b8ffecc8d@kernel.org>
Date:   Thu, 5 Aug 2021 21:49:25 +0800
From:   Chao Yu <chao@...nel.org>
To:     Tiezhu Yang <yangtiezhu@...ngson.cn>,
        Jaegeuk Kim <jaegeuk@...nel.org>
Cc:     linux-f2fs-devel@...ts.sourceforge.net,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] f2fs: Kconfig: clean up config options about compression

On 2021/8/5 21:30, Tiezhu Yang wrote:
> In fs/f2fs/Kconfig, F2FS_FS_LZ4HC depends on F2FS_FS_LZ4 and F2FS_FS_LZ4
> depends on F2FS_FS_COMPRESSION, so no need to make F2FS_FS_LZ4HC depends
> on F2FS_FS_COMPRESSION explicitly, remove the redudant "depends on", do
> the similar thing for F2FS_FS_LZORLE.
> 
> At the same time, it is better to move F2FS_FS_LZORLE next to F2FS_FS_LZO,
> it looks like a little more clear when make menuconfig, the location of
> "LZO-RLE compression support" is under "LZO compression support" instead
> of "F2FS compression feature".
> 
> Without this patch:
> 
> F2FS compression feature
>    LZO compression support
>    LZ4 compression support
>      LZ4HC compression support
>    ZSTD compression support
>    LZO-RLE compression support
> 
> With this patch:
> 
> F2FS compression feature
>    LZO compression support
>      LZO-RLE compression support
>    LZ4 compression support
>      LZ4HC compression support
>    ZSTD compression support
> 
> Signed-off-by: Tiezhu Yang <yangtiezhu@...ngson.cn>

Reviewed-by: Chao Yu <chao@...nel.org>

Thanks,