linux-kernel - Re: [PATCH] staging: r8188eu: remove label at the end of a function

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20210805143708.GO1931@kadam>
Date:   Thu, 5 Aug 2021 17:37:08 +0300
From:   Dan Carpenter <dan.carpenter@...cle.com>
To:     Martin Kaiser <martin@...ser.cx>
Cc:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Larry Finger <Larry.Finger@...inger.net>,
        Phillip Potter <phil@...lpotter.co.uk>,
        linux-staging@...ts.linux.dev, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: r8188eu: remove label at the end of a function

On Thu, Aug 05, 2021 at 03:07:50PM +0200, Martin Kaiser wrote:
> Compilation fails for me
> 
> drivers/staging/r8188eu/hal/rtl8188e_dm.c: In function ‘rtl8188e_HalDmWatchDog’:
> drivers/staging/r8188eu/hal/rtl8188e_dm.c:182:1: error: label at end of compound statement
>   182 | skip_dm:
>       | ^~~~~~~
> 
> Remove the label at the end of the function. Replace the jump to this label
> with a return statement.
> 
> Signed-off-by: Martin Kaiser <martin@...ser.cx>

This needs a Fixes tag.

regards,
dan carpenter