linux-kernel - RE: [PREEMPT_RT][PATCH] printk: Enhance the condition check of msleep in pr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 5 Aug 2021 03:01:20 +0000
From:   "Qin, Chao" <chao.qin@...el.com>
To:     John Ogness <john.ogness@...utronix.de>,
        Joe Perches <joe@...ches.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-rt-users@...r.kernel.org" <linux-rt-users@...r.kernel.org>,
        "bigeasy@...utronix.de" <bigeasy@...utronix.de>,
        "tglx@...utronix.de" <tglx@...utronix.de>,
        "rostedt@...dmis.org" <rostedt@...dmis.org>
CC:     "mgross@...ux.intel.com" <mgross@...ux.intel.com>,
        "Mei, Paul" <paul.mei@...el.com>, "Li, Lili" <lili.li@...el.com>,
        "Qin, Chao" <chao.qin@...el.com>
Subject: RE: [PREEMPT_RT][PATCH] printk: Enhance the condition check of msleep
 in pr_flush()

Hi John Ogness,

Do you have plan to backport this fix into v5.10.y-rt kernel?

Thanks,
Qin Chao.

-----Original Message-----
From: John Ogness <john.ogness@...utronix.de> 
Sent: Tuesday, July 20, 2021 10:03 PM
To: Joe Perches <joe@...ches.com>; Qin, Chao <chao.qin@...el.com>; linux-kernel@...r.kernel.org; linux-rt-users@...r.kernel.org; bigeasy@...utronix.de; tglx@...utronix.de; rostedt@...dmis.org
Cc: mgross@...ux.intel.com; Mei, Paul <paul.mei@...el.com>; Li, Lili <lili.li@...el.com>
Subject: Re: [PREEMPT_RT][PATCH] printk: Enhance the condition check of msleep in pr_flush()

On 2021-07-20, Joe Perches <joe@...ches.com> wrote:
> Logic continuations are typically at the end of the previous line.
> And there are few too many parentheses for my taste.
>
> Maybe exceed 80 columns in a single line
>
> 	may_sleep = preemptible() && !in_softirq() && system_state >= 
> SYSTEM_RUNNING;
>
> or align the continuation
>
> 	may_sleep = (preemptible() && !in_softirq() &&
> 		     system_state >= SYSTEM_RUNNING);
>
> or use individual lines
>
> 	may_sleep = (preemptible() &&
> 		     !in_softirq() &&
> 		     system_state >= SYSTEM_RUNNING);

The kernel now has a 100-column policy, but I decided to go with this third variant for easy reading.

Chao Qin, your patch will be part of the next PREEMPT_RT release. Thank you.

John Ogness