linux-kernel - Re: [PATCH v3 2/3] erofs: dax support for non-tailpacking regular file

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YQtZ+CtvB3P+7Xim@B-P7TQMD6M-0146.local>
Date:   Thu, 5 Aug 2021 11:24:40 +0800
From:   Gao Xiang <hsiangkao@...ux.alibaba.com>
To:     Chao Yu <chao@...nel.org>
Cc:     linux-erofs@...ts.ozlabs.org, linux-fsdevel@...r.kernel.org,
        nvdimm@...ts.linux.dev, LKML <linux-kernel@...r.kernel.org>,
        "Darrick J. Wong" <djwong@...nel.org>,
        Liu Bo <bo.liu@...ux.alibaba.com>,
        Joseph Qi <joseph.qi@...ux.alibaba.com>,
        Liu Jiang <gerry@...ux.alibaba.com>,
        Huang Jianan <huangjianan@...o.com>,
        Tao Ma <boyu.mt@...bao.com>
Subject: Re: [PATCH v3 2/3] erofs: dax support for non-tailpacking regular
 file

Hi Chao,

On Thu, Aug 05, 2021 at 11:01:43AM +0800, Chao Yu wrote:
> On 2021/8/5 8:36, Gao Xiang wrote:
> > DAX is quite useful for some VM use cases in order to save guest
> > memory extremely with minimal lightweight EROFS.
> > 
> > In order to prepare for such use cases, add preliminary dax support
> > for non-tailpacking regular files for now.
> > 
> > Tested with the DRAM-emulated PMEM and the EROFS image generated by
> > "mkfs.erofs -Enoinline_data enwik9.fsdax.img enwik9"
> > 
> > Cc: nvdimm@...ts.linux.dev
> > Cc: linux-fsdevel@...r.kernel.org
> > Signed-off-by: Gao Xiang <hsiangkao@...ux.alibaba.com>
> > ---
> >   Documentation/filesystems/erofs.rst |  2 +
> >   fs/erofs/data.c                     | 42 +++++++++++++++++++-
> >   fs/erofs/inode.c                    |  4 ++
> >   fs/erofs/internal.h                 |  3 ++
> >   fs/erofs/super.c                    | 59 ++++++++++++++++++++++++++++-
> >   5 files changed, 106 insertions(+), 4 deletions(-)
> > 
> > diff --git a/Documentation/filesystems/erofs.rst b/Documentation/filesystems/erofs.rst
> > index 832839fcf4c3..ffd2ae7be511 100644
> > --- a/Documentation/filesystems/erofs.rst
> > +++ b/Documentation/filesystems/erofs.rst
> > @@ -84,6 +84,8 @@ cache_strategy=%s      Select a strategy for cached decompression from now on:
> >                                      It still does in-place I/O decompression
> >                                      for the rest compressed physical clusters.
> >   		       ==========  =============================================
> > +dax                    Use direct access (no page cache).  See
> 
> dax or dax=%s
> 
> Otherwise, it looks good to me.
> 
> Reviewed-by: Chao Yu <chao@...nel.org>
> 

Thanks, it originally inherited from filesystems/ext2.rst, I will update
this into
dax, dax={always,never}      .....

Since for such image vm-shared memory scenario, no need to add per-file
DAX (at least for now.)

Thanks,
Gao Xiang

> Thanks,