linux-kernel - Re: [PATCH] power: supply: sc27xx: Delete superfluous error message

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20210805155925.7eoiuxbchwcegnyt@earth.universe>
Date:   Thu, 5 Aug 2021 17:59:25 +0200
From:   Sebastian Reichel <sebastian.reichel@...labora.com>
To:     Tang Bin <tangbin@...s.chinamobile.com>
Cc:     orsonzhai@...il.com, baolin.wang7@...il.com, zhang.lyra@...il.com,
        linux-pm@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] power: supply: sc27xx: Delete superfluous error message

Hi,

On Thu, Aug 05, 2021 at 08:52:33PM +0800, Tang Bin wrote:
> In the function sc27xx_fgu_probe(), when get irq failed,
> platform_get_irq() logs an error message, so remove
> redundant message here.
> 
> Signed-off-by: Tang Bin <tangbin@...s.chinamobile.com>
> ---

Thanks, queued.

--Sebastian

>  drivers/power/supply/sc27xx_fuel_gauge.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/drivers/power/supply/sc27xx_fuel_gauge.c b/drivers/power/supply/sc27xx_fuel_gauge.c
> index 9c627618c..5e7f7a19e 100644
> --- a/drivers/power/supply/sc27xx_fuel_gauge.c
> +++ b/drivers/power/supply/sc27xx_fuel_gauge.c
> @@ -1229,10 +1229,8 @@ static int sc27xx_fgu_probe(struct platform_device *pdev)
>  	}
>  
>  	irq = platform_get_irq(pdev, 0);
> -	if (irq < 0) {
> -		dev_err(dev, "no irq resource specified\n");
> +	if (irq < 0)
>  		return irq;
> -	}
>  
>  	ret = devm_request_threaded_irq(data->dev, irq, NULL,
>  					sc27xx_fgu_interrupt,
> -- 
> 2.20.1.windows.1
> 
> 
> 

Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)