linux-kernel - Re: [PATCH] blk-iolatency: error out if blk_get_queue() failed in iolatency_set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <cb9833b1-be92-1b52-86cb-a45a85b18c00@kernel.dk>
Date:   Thu, 5 Aug 2021 11:18:29 -0600
From:   Jens Axboe <axboe@...nel.dk>
To:     Yu Kuai <yukuai3@...wei.com>, tj@...nel.org,
        bo.liu@...ux.alibaba.com
Cc:     cgroups@...r.kernel.org, linux-block@...r.kernel.org,
        linux-kernel@...r.kernel.org, yi.zhang@...wei.com
Subject: Re: [PATCH] blk-iolatency: error out if blk_get_queue() failed in
 iolatency_set_limit()

On 8/5/21 6:46 AM, Yu Kuai wrote:
> If queue is dying while iolatency_set_limit() is in progress,
> blk_get_queue() won't increment the refcount of the queue. However,
> blk_put_queue() will still decrement the refcount later, which will
> cause the refcout to be unbalanced.
> 
> Thus error out in such case to fix the problem.

Applied, thanks.

-- 
Jens Axboe