linux-kernel - Re: [PATCH] mtd: rawnand: Fix probe failure due to of_get_nand_secure

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20210806194550.392325-1-miquel.raynal@bootlin.com>
Date:   Fri,  6 Aug 2021 21:45:50 +0200
From:   Miquel Raynal <miquel.raynal@...tlin.com>
To:     Manivannan Sadhasivam <manivannan.sadhasivam@...aro.org>,
        miquel.raynal@...tlin.com
Cc:     richard@....at, vigneshr@...com, boris.brezillon@...labora.com,
        tudor.ambarus@...rochip.com, linux-mtd@...ts.infradead.org,
        linux-kernel@...r.kernel.org, dan.carpenter@...cle.com,
        martin@...ser.cx
Subject: Re: [PATCH] mtd: rawnand: Fix probe failure due to of_get_nand_secure_regions()

On Tue, 2021-07-27 at 06:28:13 UTC, Manivannan Sadhasivam wrote:
> Due to 14f97f0b8e2b, the rawnand platforms without "secure-regions"
> property defined in DT fails to probe. The issue is,
> of_get_nand_secure_regions() errors out if
> of_property_count_elems_of_size() returns a negative error code.
> 
> If the "secure-regions" property is not present in DT, then also we'll
> get -EINVAL from of_property_count_elems_of_size() but it should not
> be treated as an error for platforms not declaring "secure-regions"
> in DT.
> 
> So fix this behaviour by checking for the existence of that property in
> DT and return 0 if it is not present.
> 
> Fixes: 14f97f0b8e2b ("mtd: rawnand: Add a check in of_get_nand_secure_regions()")
> Reported-by: Martin Kaiser <martin@...ser.cx>
> Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@...aro.org>
> Reviewed-by: Martin Kaiser <martin@...ser.cx>
> Tested-by: Martin Kaiser <martin@...ser.cx>

Applied to https://git.kernel.org/pub/scm/linux/kernel/git/mtd/linux.git mtd/fixes, thanks.

Miquel