linux-kernel - Re: [PATCH] power: supply: qcom_smbb: Remove superfluous errormessage

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 6 Aug 2021 23:38:33 +0200
From:   Sebastian Reichel <sebastian.reichel@...labora.com>
To:     tangbin <tangbin@...s.chinamobile.com>
Cc:     Bjorn Andersson <bjorn.andersson@...aro.org>, agross@...nel.org,
        linux-arm-msm@...r.kernel.org, linux-pm@...r.kernel.org,
        linux-kernel@...r.kernel.org,
        Zhang Shengju <zhangshengju@...s.chinamobile.com>
Subject: Re: [PATCH] power: supply: qcom_smbb: Remove superfluous errormessage

Hi,

On Mon, Jul 26, 2021 at 09:16:15AM +0800, tangbin wrote:
> Hi, Bjorn Andersson:
> 
> On 2021/7/20 23:52, Bjorn Andersson wrote:
> > On Tue 20 Jul 09:15 CDT 2021, Tang Bin wrote:
> > 
> > > In the probe function, when get irq failed, the function
> > > platform_get_irq_byname() logs an error message, so remove
> > > redundant message here.
> > > 
> > > Signed-off-by: Zhang Shengju <zhangshengju@...s.chinamobile.com>
> > > Signed-off-by: Tang Bin <tangbin@...s.chinamobile.com>
> > This says "Zhang certified this patch's origin, then you took the patch
> > and you certified it's origin" - per Documentation/process/submitting-patches.rst
> > 
> > But you, Tang, is the author or the patch, so how can Zhang have touched
> > it before you wrote it?
> > 
> > Perhaps you worked on it together? In which case you should include a
> > Co-developed-by to indicate this.
> 
> I am sorry for the late reply to your email due to some reasons. The correct
> way to write it should be as follows:
> 
>     Co-developed-by: Zhang Shengju <zhangshengju@...s.chinamobile.com>
> 
>     Signed-off-by: Zhang Shengju <zhangshengju@...s.chinamobile.com>
> 
>     Signed-off-by: Tang Bin <tangbin@...s.chinamobile.com>
> 
> > 
> > 
> > Both commit message and patch looks good though!
> > 
> whether should I send v2 for this patch？

Thanks, I queued the patch with the Co-developed-by tag.

-- Sebastian

> 
> Thanks
> 
> Tang Bin
> 
> > > ---
> > >   drivers/power/supply/qcom_smbb.c | 5 +----
> > >   1 file changed, 1 insertion(+), 4 deletions(-)
> > > 
> > > diff --git a/drivers/power/supply/qcom_smbb.c b/drivers/power/supply/qcom_smbb.c
> > > index c890e1cec..84cc9fba0 100644
> > > --- a/drivers/power/supply/qcom_smbb.c
> > > +++ b/drivers/power/supply/qcom_smbb.c
> > > @@ -929,11 +929,8 @@ static int smbb_charger_probe(struct platform_device *pdev)
> > >   		int irq;
> > >   		irq = platform_get_irq_byname(pdev, smbb_charger_irqs[i].name);
> > > -		if (irq < 0) {
> > > -			dev_err(&pdev->dev, "failed to get irq '%s'\n",
> > > -				smbb_charger_irqs[i].name);
> > > +		if (irq < 0)
> > >   			return irq;
> > > -		}
> > >   		smbb_charger_irqs[i].handler(irq, chg);
> > > -- 
> > > 2.20.1.windows.1
> > > 
> > > 
> > > 
> 
> 

Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)