linux-kernel - Re: [PATCH] power: supply: cpcap-battery: Use IS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20210806214713.p7ygp2iux6wjxk5n@earth.universe>
Date:   Fri, 6 Aug 2021 23:47:13 +0200
From:   Sebastian Reichel <sre@...nel.org>
To:     Tang Bin <tangbin@...s.chinamobile.com>
Cc:     linux-pm@...r.kernel.org, linux-kernel@...r.kernel.org,
        Zhang Shengju <zhangshengju@...s.chinamobile.com>
Subject: Re: [PATCH] power: supply: cpcap-battery: Use IS_ERR() to check and
 simplify code

Hi,

On Tue, Jul 20, 2021 at 02:18:36PM +0800, Tang Bin wrote:
> Use IS_ERR() and PTR_ERR() instead of PTR_ERR_OR_ZERO() to
> simplify code, avoid redundant judgements.
> 
> Signed-off-by: Zhang Shengju <zhangshengju@...s.chinamobile.com>
> Signed-off-by: Tang Bin <tangbin@...s.chinamobile.com>
> ---

I think the original variant is the simpler one. Also
compiler should be able to optimize this.

-- Sebastian

>  drivers/power/supply/cpcap-battery.c | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/power/supply/cpcap-battery.c b/drivers/power/supply/cpcap-battery.c
> index 90eba3646..7007e5d53 100644
> --- a/drivers/power/supply/cpcap-battery.c
> +++ b/drivers/power/supply/cpcap-battery.c
> @@ -912,10 +912,9 @@ static int cpcap_battery_probe(struct platform_device *pdev)
>  
>  	ddata->psy = devm_power_supply_register(ddata->dev, psy_desc,
>  						&psy_cfg);
> -	error = PTR_ERR_OR_ZERO(ddata->psy);
> -	if (error) {
> +	if (IS_ERR(ddata->psy)) {
>  		dev_err(ddata->dev, "failed to register power supply\n");
> -		return error;
> +		return PTR_ERR(ddata->psy);
>  	}
>  
>  	atomic_set(&ddata->active, 1);
> -- 
> 2.20.1.windows.1
> 
> 
> 

Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)