linux-kernel - Re: [PATCH] pinctrl: zynqmp: Drop pinctrl_unregister for devm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 6 Aug 2021 09:45:53 +0200
From:   Michal Simek <michal.simek@...inx.com>
To:     Yang Yingliang <yangyingliang@...wei.com>,
        <linux-kernel@...r.kernel.org>
CC:     <linus.walleij@...aro.org>, <michal.simek@...inx.com>,
        <lakshmi.sai.krishna.potthuri@...inx.com>
Subject: Re: [PATCH] pinctrl: zynqmp: Drop pinctrl_unregister for devm_
 registered device



On 7/29/21 9:19 AM, Yang Yingliang wrote:
> It's not necessary to unregister pin controller device registered
> with devm_pinctrl_register() and using pinctrl_unregister() leads
> to a double free.
> 
> Fixes: fa99e7013827 ("pinctrl: zynqmp: some code cleanups")
> Signed-off-by: Yang Yingliang <yangyingliang@...wei.com>
> ---
>  drivers/pinctrl/pinctrl-zynqmp.c | 10 ----------
>  1 file changed, 10 deletions(-)
> 
> diff --git a/drivers/pinctrl/pinctrl-zynqmp.c b/drivers/pinctrl/pinctrl-zynqmp.c
> index bbde676b7313..e14012209992 100644
> --- a/drivers/pinctrl/pinctrl-zynqmp.c
> +++ b/drivers/pinctrl/pinctrl-zynqmp.c
> @@ -866,15 +866,6 @@ static int zynqmp_pinctrl_probe(struct platform_device *pdev)
>  	return ret;
>  }
>  
> -static int zynqmp_pinctrl_remove(struct platform_device *pdev)
> -{
> -	struct zynqmp_pinctrl *pctrl = platform_get_drvdata(pdev);
> -
> -	pinctrl_unregister(pctrl->pctrl);
> -
> -	return 0;
> -}
> -
>  static const struct of_device_id zynqmp_pinctrl_of_match[] = {
>  	{ .compatible = "xlnx,zynqmp-pinctrl" },
>  	{ }
> @@ -887,7 +878,6 @@ static struct platform_driver zynqmp_pinctrl_driver = {
>  		.of_match_table = zynqmp_pinctrl_of_match,
>  	},
>  	.probe = zynqmp_pinctrl_probe,
> -	.remove = zynqmp_pinctrl_remove,
>  };
>  module_platform_driver(zynqmp_pinctrl_driver);
>  
>

Reviewed-by: Michal Simek <michal.simek@...inx.com>

Thanks,
Michal