[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <f38ad6edfb6ee63f273a430154e1038f@kernel.org>
Date: Fri, 06 Aug 2021 09:29:02 +0100
From: Marc Zyngier <maz@...nel.org>
To: Pali Rohár <pali@...nel.org>
Cc: Lorenzo Pieralisi <lorenzo.pieralisi@....com>,
Thomas Petazzoni <thomas.petazzoni@...tlin.com>,
Bjorn Helgaas <bhelgaas@...gle.com>,
Rob Herring <robh@...nel.org>,
Marek Behún <kabel@...nel.org>,
linux-pci@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/7] PCI: aardvark: Check for virq mapping when processing
INTx IRQ
On 2021-06-25 10:03, Pali Rohár wrote:
> It is possible that we receive spurious INTx interrupt. So add needed
> check
> before calling generic_handle_irq() function.
>
> Signed-off-by: Pali Rohár <pali@...nel.org>
> Reviewed-by: Marek Behún <kabel@...nel.org>
> Cc: stable@...r.kernel.org
> ---
> drivers/pci/controller/pci-aardvark.c | 6 +++++-
> 1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/pci/controller/pci-aardvark.c
> b/drivers/pci/controller/pci-aardvark.c
> index 36fcc077ec72..59f91fad2481 100644
> --- a/drivers/pci/controller/pci-aardvark.c
> +++ b/drivers/pci/controller/pci-aardvark.c
> @@ -1226,7 +1226,11 @@ static void advk_pcie_handle_int(struct
> advk_pcie *pcie)
> PCIE_ISR1_REG);
>
> virq = irq_find_mapping(pcie->irq_domain, i);
> - generic_handle_irq(virq);
> + if (virq)
> + generic_handle_irq(virq);
> + else
> + dev_err_ratelimited(&pcie->pdev->dev, "unexpected INT%c IRQ\n",
> + (char)i+'A');
> }
> }
Please use generic_handle_domain_irq() instead of irq_find_mapping()
and generic_handle_irq().
Thanks,
M.
--
Jazz is not dead. It just smells funny...
Powered by blists - more mailing lists