linux-kernel - Re: [RFT, PATCH v1 1/1] platform/x86: dell-smo8800: Convert to be a platform driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YQz7DV4lOSD7+RJ8@smile.fi.intel.com>
Date:   Fri, 6 Aug 2021 12:04:13 +0300
From:   Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To:     Pali Rohár <pali@...nel.org>
Cc:     Hans de Goede <hdegoede@...hat.com>,
        platform-driver-x86@...r.kernel.org, linux-kernel@...r.kernel.org,
        Mark Gross <mgross@...ux.intel.com>
Subject: Re: [RFT, PATCH v1 1/1] platform/x86: dell-smo8800: Convert to be a
 platform driver

On Thu, Aug 05, 2021 at 09:22:21PM +0200, Pali Rohár wrote:
> On Tuesday 03 August 2021 22:40:39 Andy Shevchenko wrote:
> > ACPI core in conjunction with platform driver core provides
> > an infrastructure to enumerate ACPI devices. Use it in order
> > to remove a lot of boilerplate code.
> > 
> > Signed-off-by: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
> 
> Tested on Dell Latitude E6440. After applying this patch /dev/freefall
> device is created and can be opened (for waiting for disk fall). Also
> interrupt is registered in /proc/interrupts file:
> 
>  23:          0          0          0          0  IR-IO-APIC  23-edge      smo8800
> 
> But I have not done real hard disk fall on this machine :-) so I guess
> it would work as before applying this patch.

At least the change doesn't touch any functional parts except device driver
enumeration.

> Reviewed-by: Pali Rohár <pali@...nel.org>
> Tested-by: Pali Rohár <pali@...nel.org>

Thank you!

-- 
With Best Regards,
Andy Shevchenko