linux-kernel - [PATCH][next] fuse: Fix uninitiailized error return in variable err

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-Id: <20210806095027.8408-1-colin.king@canonical.com>
Date:   Fri,  6 Aug 2021 10:50:27 +0100
From:   Colin King <colin.king@...onical.com>
To:     Miklos Szeredi <miklos@...redi.hu>, linux-fsdevel@...r.kernel.org
Cc:     kernel-janitors@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: [PATCH][next] fuse: Fix uninitiailized error return in variable err

From: Colin Ian King <colin.king@...onical.com>

There is an error return path where err is being returned but
it not been yet set. Fix this by just returning -EINVAL.

Addresses-Coverity: ("Uninitialized scalar variable")
Fixes: ff12b2314569 ("fuse: move fget() to fuse_get_tree()")
Signed-off-by: Colin Ian King <colin.king@...onical.com>
---
 fs/fuse/inode.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/fuse/inode.c b/fs/fuse/inode.c
index 0580a8319593..09adb4f4734e 100644
--- a/fs/fuse/inode.c
+++ b/fs/fuse/inode.c
@@ -1522,7 +1522,7 @@ static int fuse_fill_super(struct super_block *sb, struct fs_context *fsc)
 	 */
 	if ((ctx->file->f_op != &fuse_dev_operations) ||
 	    (ctx->file->f_cred->user_ns != sb->s_user_ns))
-		goto err;
+		return -EINVAL;
 	ctx->fudptr = &ctx->file->private_data;
 
 	fc = kmalloc(sizeof(*fc), GFP_KERNEL);
-- 
2.31.1