linux-kernel - Reference to non-existing DYNAMIC_FTRACE_WITH

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAKXUXMwT2zS9fgyQHKUUiqo8ynZBdx2UEUu1WnV_q0OCmknqhw@mail.gmail.com>
Date:   Fri, 6 Aug 2021 12:18:36 +0200
From:   Lukas Bulwahn <lukas.bulwahn@...il.com>
To:     "Steven Rostedt (VMware)" <rostedt@...dmis.org>
Cc:     live-patching@...r.kernel.org,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Ingo Molnar <mingo@...hat.com>,
        Josh Poimboeuf <jpoimboe@...hat.com>,
        Petr Mladek <pmladek@...e.com>,
        Joe Lawrence <joe.lawrence@...hat.com>,
        Jiri Kosina <jikos@...nel.org>,
        Miroslav Benes <mbenes@...e.cz>,
        kernel-janitors <kernel-janitors@...r.kernel.org>
Subject: Reference to non-existing DYNAMIC_FTRACE_WITH_ARGS

Hi Steven,

Commit 2860cd8a2353 ("livepatch: Use the default ftrace_ops instead of
REGS when ARGS is available") adds a dependency on a non-existing
config DYNAMIC_FTRACE_WITH_ARGS, see diff:

diff --git a/kernel/livepatch/Kconfig b/kernel/livepatch/Kconfig
index 54102deb50ba..53d51ed619a3 100644
--- a/kernel/livepatch/Kconfig
+++ b/kernel/livepatch/Kconfig
@@ -6,7 +6,7 @@ config HAVE_LIVEPATCH

 config LIVEPATCH
        bool "Kernel Live Patching"
-       depends on DYNAMIC_FTRACE_WITH_REGS
+       depends on DYNAMIC_FTRACE_WITH_REGS || DYNAMIC_FTRACE_WITH_ARGS
        depends on MODULES
        depends on SYSFS
        depends on KALLSYMS_ALL


Did you intend to depend on the existing "HAVE_DYNAMIC_FTRACE_WITH_ARGS" here?

Or did you intend to add a new config DYNAMIC_FTRACE_WITH_ARGS
analogously to DYNAMIC_FTRACE_WITH_REGS as defined in
./kernel/trace/Kconfig (see below)?

config DYNAMIC_FTRACE_WITH_REGS
        def_bool y
        depends on DYNAMIC_FTRACE
        depends on HAVE_DYNAMIC_FTRACE_WITH_REGS

I am happy to provide a patch, once I understand what was intended here.

Lukas