[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <a5580cf5-9fcc-252d-5835-f199469516b0@oracle.com>
Date: Thu, 5 Aug 2021 18:00:52 -0700
From: Jane Chu <jane.chu@...cle.com>
To: Shiyang Ruan <ruansy.fnst@...itsu.com>,
linux-kernel@...r.kernel.org, linux-xfs@...r.kernel.org,
nvdimm@...ts.linux.dev, linux-mm@...ck.org,
linux-fsdevel@...r.kernel.org, dm-devel@...hat.com
Cc: djwong@...nel.org, dan.j.williams@...el.com, david@...morbit.com,
hch@....de, agk@...hat.com, snitzer@...hat.com
Subject: Re: [PATCH RESEND v6 3/9] mm: factor helpers for
memory_failure_dev_pagemap
On 7/30/2021 3:01 AM, Shiyang Ruan wrote:
> - /*
> - * Prevent the inode from being freed while we are interrogating
> - * the address_space, typically this would be handled by
> - * lock_page(), but dax pages do not use the page lock. This
> - * also prevents changes to the mapping of this pfn until
> - * poison signaling is complete.
> - */
> - cookie = dax_lock_page(page);
> - if (!cookie)
> - goto out;
> -
> if (hwpoison_filter(page)) {
> rc = 0;
> - goto unlock;
> + goto out;
> }
why isn't dax_lock_page() needed for hwpoison_filter() check?
thanks,
-jane
Powered by blists - more mailing lists