linux-kernel - Re: [PATCH 1/6] crypto: omap-sham - clear dma flags only after omap_sham_update_dma

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20210806121426.GA25554@gondor.apana.org.au>
Date:   Fri, 6 Aug 2021 20:14:26 +0800
From:   Herbert Xu <herbert@...dor.apana.org.au>
To:     Tony Lindgren <tony@...mide.com>
Cc:     "David S . Miller" <davem@...emloft.net>,
        linux-kernel@...r.kernel.org, linux-omap@...r.kernel.org,
        linux-crypto@...r.kernel.org, Lokesh Vutla <lokeshvutla@...com>,
        Tero Kristo <kristo@...nel.org>
Subject: Re: [PATCH 1/6] crypto: omap-sham - clear dma flags only after
 omap_sham_update_dma_stop()

On Tue, Jul 27, 2021 at 01:23:34PM +0300, Tony Lindgren wrote:
> We should not clear FLAGS_DMA_ACTIVE before omap_sham_update_dma_stop() is
> done calling dma_unmap_sg(). We already clear FLAGS_DMA_ACTIVE at the
> end of omap_sham_update_dma_stop().
> 
> The early clearing of FLAGS_DMA_ACTIVE is not causing issues as we do not
> need to defer anything based on FLAGS_DMA_ACTIVE currently. So this can be
> applied as clean-up.
> 
> Cc: Lokesh Vutla <lokeshvutla@...com>
> Cc: Tero Kristo <kristo@...nel.org>
> Signed-off-by: Tony Lindgren <tony@...mide.com>
> ---
>  drivers/crypto/omap-sham.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

All applied.  Thanks.
-- 
Email: Herbert Xu <herbert@...dor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt