linux-kernel - Re: [PATCH v2] rtl8xxxu: Fix the handling of TX A-MPDU aggregation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87o8aabvpj.fsf@codeaurora.org>
Date:   Fri, 06 Aug 2021 15:31:52 +0300
From:   Kalle Valo <kvalo@...eaurora.org>
To:     Reto Schneider <rs@....ch>
Cc:     chris.chiu@...onical.com, code@...o-schneider.ch,
        linux-wireless@...r.kernel.org, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org, jes.sorensen@...il.com,
        davem@...emloft.net, kuba@...nel.org
Subject: Re: [PATCH v2] rtl8xxxu: Fix the handling of TX A-MPDU aggregation

Reto Schneider <rs@....ch> writes:

> On 8/4/21 17:13, chris.chiu@...onical.com wrote:
>> The TX A-MPDU aggregation is not handled in the driver since the
>> ieee80211_start_tx_ba_session has never been started properly.
>> Start and stop the TX BA session by tracking the TX aggregation
>> status of each TID. Fix the ampdu_action and the tx descriptor
>> accordingly with the given TID.
>
> I'd like to test this but I am not sure what to look for (before and
> after applying the patch).

Thanks, testing feedback is always very much appreciated.

> What should I look for when looking at the (sniffed) Wireshark traces?

>From my (maintainer) point of view most important is that there are no
regressions visible to users, for example no data stalls, crashes or
anything like that.

-- 
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches