linux-kernel - Re: [PATCH][next] brcmfmac: firmware: Fix uninitialized variable ret

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <87eeb6bvk6.fsf@codeaurora.org>
Date:   Fri, 06 Aug 2021 15:35:05 +0300
From:   Kalle Valo <kvalo@...eaurora.org>
To:     Colin Ian King <colin.king@...onical.com>
Cc:     Arend van Spriel <arend.vanspriel@...adcom.com>,
        Linus Walleij <linus.walleij@...aro.org>,
        Arend van Spriel <aspriel@...il.com>,
        Franky Lin <franky.lin@...adcom.com>,
        Hante Meuleman <hante.meuleman@...adcom.com>,
        Chi-hsien Lin <chi-hsien.lin@...ineon.com>,
        Wright Feng <wright.feng@...ineon.com>,
        Chung-hsien Hsu <chung-hsien.hsu@...ineon.com>,
        "David S . Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>,
        linux-wireless <linux-wireless@...r.kernel.org>,
        brcm80211-dev-list.pdl@...adcom.com,
        SHA-cyfmac-dev-list@...ineon.com, netdev <netdev@...r.kernel.org>,
        kernel-janitors@...r.kernel.org,
        linux-kernel <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH][next] brcmfmac: firmware: Fix uninitialized variable ret

Colin Ian King <colin.king@...onical.com> writes:

> On 06/08/2021 12:23, Arend van Spriel wrote:
>> On 05-08-2021 15:53, Kalle Valo wrote:
>>> Linus Walleij <linus.walleij@...aro.org> writes:
>>>
>>>> On Tue, Aug 3, 2021 at 5:09 PM Colin King <colin.king@...onical.com>
>>>> wrote:
>>>>
>>>>> From: Colin Ian King <colin.king@...onical.com>
>>>>>
>>>>> Currently the variable ret is uninitialized and is only set if
>>>>> the pointer alt_path is non-null. Fix this by ininitializing ret
>>>>> to zero.
>>>>>
>>>>> Addresses-Coverity: ("Uninitialized scalar variable")
>>>>> Fixes: 5ff013914c62 ("brcmfmac: firmware: Allow per-board firmware
>>>>> binaries")
>>>>> Signed-off-by: Colin Ian King <colin.king@...onical.com>
>>>>
>>>> Nice catch!
>>>> Reviewed-by: Linus Walleij <linus.walleij@...aro.org>
>>>
>>> I assume this will be fixed by Linus' patch "brcmfmac: firmware: Fix
>>> firmware loading" and I should drop Colin's patch, correct?
>> 
>> That would be my assumption as well, but not sure when he will submit
>> another revision of it. You probably know what to do ;-)
>
> I'd prefer my patch to be dropped in preference to Linus' fix.

Ok, I'll then drop Colin's patch.

-- 
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches