linux-kernel - Re: [PATCH v1 1/1] iio: cros_ec: Fix Kconfig dependency on CROS_EC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CABXOdTfXzdJE0Nye-rttp50cnTJy-nU9RcFxkONDo3hXvVWDUA@mail.gmail.com>
Date:   Fri, 6 Aug 2021 08:04:18 -0700
From:   Guenter Roeck <groeck@...gle.com>
To:     Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Cc:     linux-iio@...r.kernel.org,
        linux-kernel <linux-kernel@...r.kernel.org>,
        Jonathan Cameron <jic23@...nel.org>,
        Lars-Peter Clausen <lars@...afoo.de>,
        Benson Leung <bleung@...omium.org>,
        Enric Balletbo i Serra <enric.balletbo@...labora.com>,
        Guenter Roeck <groeck@...omium.org>,
        "Jason M ." <jason@...tleon.com>
Subject: Re: [PATCH v1 1/1] iio: cros_ec: Fix Kconfig dependency on CROS_EC_SENSORHUB

Trying again, text only this time. Sorry for the trouble.

On Fri, Aug 6, 2021 at 6:08 AM Andy Shevchenko
<andriy.shevchenko@...ux.intel.com> wrote:
>
> When CONFIG_CROS_EC_SENSORHUB is set to m, the IIO_CROS_EC_SENSORS_CORE
> can't be built-in.
>
> Fixes: 53067471188c ("iio / platform: cros_ec: Add cros-ec-sensorhub driver")
> BugLink: https://bugzilla.kernel.org/show_bug.cgi?id=213979
> Reported-by: Jason M. <jason@...tleon.com>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
> ---
>  drivers/iio/common/cros_ec_sensors/Kconfig | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/iio/common/cros_ec_sensors/Kconfig b/drivers/iio/common/cros_ec_sensors/Kconfig
> index fefad9572790..b0d67ceaed55 100644
> --- a/drivers/iio/common/cros_ec_sensors/Kconfig
> +++ b/drivers/iio/common/cros_ec_sensors/Kconfig
> @@ -4,7 +4,8 @@
>  #
>  config IIO_CROS_EC_SENSORS_CORE
>         tristate "ChromeOS EC Sensors Core"
> -       depends on SYSFS && CROS_EC_SENSORHUB
> +       depends on CROS_EC_SENSORHUB=y || (CROS_EC_SENSORHUB=m && m)
> +       depends on SYSFS

This seems wrong.  IIO_CROS_EC_SENSORS_CORE should already be limited to m
if CROS_EC_SENSORHUB=m.

Note that I can not reproduce the problem in the bugzilla entry,
neither with mainline
nor with v5.13.6. And the configuration file published there looks fine and
already has IIO_CROS_EC_SENSORS_CORE=m.

Guenter

>         select IIO_BUFFER
>         select IIO_TRIGGERED_BUFFER
>         help
> --
> 2.30.2
>