linux-kernel - [PATCH -next] erofs: make symbol 'erofs_iomap

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:   Sun, 8 Aug 2021 06:33:43 +0000
From:   Wei Yongjun <weiyongjun1@...wei.com>
To:     <weiyongjun1@...wei.com>, Huang Jianan <huangjianan@...o.com>,
        Gao Xiang <xiang@...nel.org>, Chao Yu <chao@...nel.org>
CC:     <linux-erofs@...ts.ozlabs.org>, <linux-kernel@...r.kernel.org>,
        <kernel-janitors@...r.kernel.org>, Hulk Robot <hulkci@...wei.com>
Subject: [PATCH -next] erofs: make symbol 'erofs_iomap_ops' static

The sparse tool complains as follows:

fs/erofs/data.c:150:24: warning:
 symbol 'erofs_iomap_ops' was not declared. Should it be static?

This symbol is not used outside of data.c, so marks it static.

Fixes: 3e9ce908c114 ("erofs: iomap support for non-tailpacking DIO")
Reported-by: Hulk Robot <hulkci@...wei.com>
Signed-off-by: Wei Yongjun <weiyongjun1@...wei.com>
---
 fs/erofs/data.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/erofs/data.c b/fs/erofs/data.c
index 4ea10b31790c..b2a22aabc9bc 100644
--- a/fs/erofs/data.c
+++ b/fs/erofs/data.c
@@ -147,7 +147,7 @@ static int erofs_iomap_end(struct inode *inode, loff_t pos, loff_t length,
 	return written;
 }
 
-const struct iomap_ops erofs_iomap_ops = {
+static const struct iomap_ops erofs_iomap_ops = {
 	.iomap_begin = erofs_iomap_begin,
 	.iomap_end = erofs_iomap_end,
 };