| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <0d75f283-50b7-460d-3165-185cb955bd70@linux.intel.com>
Date: Sun, 8 Aug 2021 18:41:54 -0700
From: "Kuppuswamy, Sathyanarayanan"
<sathyanarayanan.kuppuswamy@...ux.intel.com>
To: Tom Lendacky <thomas.lendacky@....com>,
linux-kernel@...r.kernel.org, x86@...nel.org,
linuxppc-dev@...ts.ozlabs.org, linux-s390@...r.kernel.org,
iommu@...ts.linux-foundation.org, kvm@...r.kernel.org,
linux-efi@...r.kernel.org, platform-driver-x86@...r.kernel.org,
linux-graphics-maintainer@...are.com,
amd-gfx@...ts.freedesktop.org, dri-devel@...ts.freedesktop.org,
kexec@...ts.infradead.org, linux-fsdevel@...r.kernel.org
Cc: Borislav Petkov <bp@...en8.de>,
Brijesh Singh <brijesh.singh@....com>,
Joerg Roedel <joro@...tes.org>,
Andi Kleen <ak@...ux.intel.com>,
Tianyu Lan <Tianyu.Lan@...rosoft.com>,
Andy Lutomirski <luto@...nel.org>,
Ard Biesheuvel <ardb@...nel.org>, Baoquan He <bhe@...hat.com>,
Benjamin Herrenschmidt <benh@...nel.crashing.org>,
Christian Borntraeger <borntraeger@...ibm.com>,
Daniel Vetter <daniel@...ll.ch>,
Dave Hansen <dave.hansen@...ux.intel.com>,
Dave Young <dyoung@...hat.com>,
David Airlie <airlied@...ux.ie>,
Heiko Carstens <hca@...ux.ibm.com>,
Ingo Molnar <mingo@...hat.com>,
Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>,
Maxime Ripard <mripard@...nel.org>,
Michael Ellerman <mpe@...erman.id.au>,
Paul Mackerras <paulus@...ba.org>,
Peter Zijlstra <peterz@...radead.org>,
Thomas Gleixner <tglx@...utronix.de>,
Thomas Zimmermann <tzimmermann@...e.de>,
Vasily Gorbik <gor@...ux.ibm.com>,
Will Deacon <will@...nel.org>
Subject: Re: [PATCH 00/11] Implement generic prot_guest_has() helper function
Hi Tom,
On 7/27/21 3:26 PM, Tom Lendacky wrote:
> This patch series provides a generic helper function, prot_guest_has(),
> to replace the sme_active(), sev_active(), sev_es_active() and
> mem_encrypt_active() functions.
>
> It is expected that as new protected virtualization technologies are
> added to the kernel, they can all be covered by a single function call
> instead of a collection of specific function calls all called from the
> same locations.
>
> The powerpc and s390 patches have been compile tested only. Can the
> folks copied on this series verify that nothing breaks for them.
With this patch set, select ARCH_HAS_PROTECTED_GUEST and set
CONFIG_AMD_MEM_ENCRYPT=n, creates following error.
ld: arch/x86/mm/ioremap.o: in function `early_memremap_is_setup_data':
arch/x86/mm/ioremap.c:672: undefined reference to `early_memremap_decrypted'
It looks like early_memremap_is_setup_data() is not protected with
appropriate config.
>
> Cc: Andi Kleen <ak@...ux.intel.com>
> Cc: Andy Lutomirski <luto@...nel.org>
> Cc: Ard Biesheuvel <ardb@...nel.org>
> Cc: Baoquan He <bhe@...hat.com>
> Cc: Benjamin Herrenschmidt <benh@...nel.crashing.org>
> Cc: Borislav Petkov <bp@...en8.de>
> Cc: Christian Borntraeger <borntraeger@...ibm.com>
> Cc: Daniel Vetter <daniel@...ll.ch>
> Cc: Dave Hansen <dave.hansen@...ux.intel.com>
> Cc: Dave Young <dyoung@...hat.com>
> Cc: David Airlie <airlied@...ux.ie>
> Cc: Heiko Carstens <hca@...ux.ibm.com>
> Cc: Ingo Molnar <mingo@...hat.com>
> Cc: Joerg Roedel <joro@...tes.org>
> Cc: Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>
> Cc: Maxime Ripard <mripard@...nel.org>
> Cc: Michael Ellerman <mpe@...erman.id.au>
> Cc: Paul Mackerras <paulus@...ba.org>
> Cc: Peter Zijlstra <peterz@...radead.org>
> Cc: Thomas Gleixner <tglx@...utronix.de>
> Cc: Thomas Zimmermann <tzimmermann@...e.de>
> Cc: Vasily Gorbik <gor@...ux.ibm.com>
> Cc: VMware Graphics <linux-graphics-maintainer@...are.com>
> Cc: Will Deacon <will@...nel.org>
>
> ---
>
> Patches based on:
> https://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git master
> commit 79e920060fa7 ("Merge branch 'WIP/fixes'")
>
> Tom Lendacky (11):
> mm: Introduce a function to check for virtualization protection
> features
> x86/sev: Add an x86 version of prot_guest_has()
> powerpc/pseries/svm: Add a powerpc version of prot_guest_has()
> x86/sme: Replace occurrences of sme_active() with prot_guest_has()
> x86/sev: Replace occurrences of sev_active() with prot_guest_has()
> x86/sev: Replace occurrences of sev_es_active() with prot_guest_has()
> treewide: Replace the use of mem_encrypt_active() with
> prot_guest_has()
> mm: Remove the now unused mem_encrypt_active() function
> x86/sev: Remove the now unused mem_encrypt_active() function
> powerpc/pseries/svm: Remove the now unused mem_encrypt_active()
> function
> s390/mm: Remove the now unused mem_encrypt_active() function
>
> arch/Kconfig | 3 ++
> arch/powerpc/include/asm/mem_encrypt.h | 5 --
> arch/powerpc/include/asm/protected_guest.h | 30 +++++++++++
> arch/powerpc/platforms/pseries/Kconfig | 1 +
> arch/s390/include/asm/mem_encrypt.h | 2 -
> arch/x86/Kconfig | 1 +
> arch/x86/include/asm/kexec.h | 2 +-
> arch/x86/include/asm/mem_encrypt.h | 13 +----
> arch/x86/include/asm/protected_guest.h | 27 ++++++++++
> arch/x86/kernel/crash_dump_64.c | 4 +-
> arch/x86/kernel/head64.c | 4 +-
> arch/x86/kernel/kvm.c | 3 +-
> arch/x86/kernel/kvmclock.c | 4 +-
> arch/x86/kernel/machine_kexec_64.c | 19 +++----
> arch/x86/kernel/pci-swiotlb.c | 9 ++--
> arch/x86/kernel/relocate_kernel_64.S | 2 +-
> arch/x86/kernel/sev.c | 6 +--
> arch/x86/kvm/svm/svm.c | 3 +-
> arch/x86/mm/ioremap.c | 16 +++---
> arch/x86/mm/mem_encrypt.c | 60 +++++++++++++++-------
> arch/x86/mm/mem_encrypt_identity.c | 3 +-
> arch/x86/mm/pat/set_memory.c | 3 +-
> arch/x86/platform/efi/efi_64.c | 9 ++--
> arch/x86/realmode/init.c | 8 +--
> drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 4 +-
> drivers/gpu/drm/drm_cache.c | 4 +-
> drivers/gpu/drm/vmwgfx/vmwgfx_drv.c | 4 +-
> drivers/gpu/drm/vmwgfx/vmwgfx_msg.c | 6 +--
> drivers/iommu/amd/init.c | 7 +--
> drivers/iommu/amd/iommu.c | 3 +-
> drivers/iommu/amd/iommu_v2.c | 3 +-
> drivers/iommu/iommu.c | 3 +-
> fs/proc/vmcore.c | 6 +--
> include/linux/mem_encrypt.h | 4 --
> include/linux/protected_guest.h | 37 +++++++++++++
> kernel/dma/swiotlb.c | 4 +-
> 36 files changed, 218 insertions(+), 104 deletions(-)
> create mode 100644 arch/powerpc/include/asm/protected_guest.h
> create mode 100644 arch/x86/include/asm/protected_guest.h
> create mode 100644 include/linux/protected_guest.h
>
--
Sathyanarayanan Kuppuswamy
Linux Kernel Developer
Powered by blists - more mailing lists