linux-kernel - Re: [PATCH v4 1/2] blk-zoned: allow zone management send operations without CAP_SYS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <PH0PR04MB74168FFA5B2B108429077E829BF69@PH0PR04MB7416.namprd04.prod.outlook.com>
Date:   Mon, 9 Aug 2021 09:57:43 +0000
From:   Johannes Thumshirn <Johannes.Thumshirn@....com>
To:     Niklas Cassel <Niklas.Cassel@....com>,
        Jens Axboe <axboe@...nel.dk>, Hannes Reinecke <hare@...e.com>,
        "Martin K. Petersen" <martin.petersen@...cle.com>,
        Shaun Tancheff <shaun@...cheff.com>,
        Damien Le Moal <Damien.LeMoal@....com>
CC:     Aravind Ramesh <Aravind.Ramesh@....com>,
        Adam Manzanares <a.manzanares@...sung.com>,
        Himanshu Madhani <himanshu.madhani@...cle.com>,
        "stable@...r.kernel.org" <stable@...r.kernel.org>,
        Jens Axboe <axboe@...com>,
        "linux-block@...r.kernel.org" <linux-block@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v4 1/2] blk-zoned: allow zone management send operations
 without CAP_SYS_ADMIN

On 09/08/2021 11:50, Niklas Cassel wrote:
> From: Niklas Cassel <niklas.cassel@....com>
> 
> Zone management send operations (BLKRESETZONE, BLKOPENZONE, BLKCLOSEZONE
> and BLKFINISHZONE) should be allowed under the same permissions as write().
> (write() does not require CAP_SYS_ADMIN).
> 
> Additionally, other ioctls like BLKSECDISCARD and BLKZEROOUT only check if
> the fd was successfully opened with FMODE_WRITE.
> (They do not require CAP_SYS_ADMIN).
> 
> Currently, zone management send operations require both CAP_SYS_ADMIN
> and that the fd was successfully opened with FMODE_WRITE.
> 
> Remove the CAP_SYS_ADMIN requirement, so that zone management send
> operations match the access control requirement of write(), BLKSECDISCARD
> and BLKZEROOUT.
> 
> Fixes: 3ed05a987e0f ("blk-zoned: implement ioctls")
> Signed-off-by: Niklas Cassel <niklas.cassel@....com>
> Reviewed-by: Damien Le Moal <damien.lemoal@....com>
> Reviewed-by: Aravind Ramesh <aravind.ramesh@....com>
> Reviewed-by: Adam Manzanares <a.manzanares@...sung.com>
> Reviewed-by: Himanshu Madhani <himanshu.madhani@...cle.com>
> Cc: stable@...r.kernel.org # v4.10+
> ---

Looks good,
Reviewed-by: Johannes Thumshirn <johannes.thumshirn@....com>