linux-kernel - Re: [PATCH -next] erofs: make symbol 'erofs_iomap

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <82bae76e-8811-22d4-0b75-f58df1153def@huawei.com>
Date:   Mon, 9 Aug 2021 10:49:31 +0800
From:   "weiyongjun (A)" <weiyongjun1@...wei.com>
To:     Chao Yu <chao@...nel.org>, Gao Xiang <hsiangkao@...ux.alibaba.com>
CC:     Huang Jianan <huangjianan@...o.com>, Gao Xiang <xiang@...nel.org>,
        <linux-erofs@...ts.ozlabs.org>, <linux-kernel@...r.kernel.org>,
        <kernel-janitors@...r.kernel.org>, Hulk Robot <hulkci@...wei.com>
Subject: Re: [PATCH -next] erofs: make symbol 'erofs_iomap_ops' static


在 2021/8/9 7:56, Chao Yu 写道:
> On 2021/8/8 21:19, Gao Xiang wrote:
>> On Sun, Aug 08, 2021 at 06:33:43AM +0000, Wei Yongjun wrote:
>>> The sparse tool complains as follows:
>>>
>>> fs/erofs/data.c:150:24: warning:
>>>   symbol 'erofs_iomap_ops' was not declared. Should it be static?
>>>
>>> This symbol is not used outside of data.c, so marks it static.
>
> Thanks for the patch, I guess it will be better to fix in original patch
> if you don't mind.


Yes, better to fix in original patch.

Regards.