linux-kernel - Re: [PATCH 2/3] mmc: sdhci-of-arasan: Add intel Thunder Bay SOC support to the arasan eMMC driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAPDyKFp5HcCfsoLgBc=D9RKOrVY2SuV3FKsFCVT2=WaxZBsNiA@mail.gmail.com>
Date:   Mon, 9 Aug 2021 14:13:18 +0200
From:   Ulf Hansson <ulf.hansson@...aro.org>
To:     "A, Rashmi" <rashmi.a@...el.com>
Cc:     Vinod Koul <vkoul@...nel.org>,
        Michal Simek <michal.simek@...inx.com>,
        linux-mmc <linux-mmc@...r.kernel.org>,
        Linux ARM <linux-arm-kernel@...ts.infradead.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Kishon <kishon@...com>,
        Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
        "linux-phy@...ts.infradead.org" <linux-phy@...ts.infradead.org>,
        Mark Gross <mgross@...ux.intel.com>,
        "kris.pan@...ux.intel.com" <kris.pan@...ux.intel.com>,
        "Zhou, Furong" <furong.zhou@...el.com>,
        "Sangannavar, Mallikarjunappa" 
        <mallikarjunappa.sangannavar@...el.com>,
        "Hunter, Adrian" <adrian.hunter@...el.com>,
        "Vaidya, Mahesh R" <mahesh.r.vaidya@...el.com>,
        "Srikandan, Nandhini" <nandhini.srikandan@...el.com>,
        "Demakkanavar, Kenchappa" <kenchappa.demakkanavar@...el.com>
Subject: Re: [PATCH 2/3] mmc: sdhci-of-arasan: Add intel Thunder Bay SOC
 support to the arasan eMMC driver

On Mon, 9 Aug 2021 at 13:17, A, Rashmi <rashmi.a@...el.com> wrote:
>
>
>
> > -----Original Message-----
> > From: Vinod Koul <vkoul@...nel.org>
> > Sent: Monday, August 9, 2021 2:12 PM
> > To: A, Rashmi <rashmi.a@...el.com>
> > Cc: Ulf Hansson <ulf.hansson@...aro.org>; Michal Simek
> > <michal.simek@...inx.com>; linux-mmc <linux-mmc@...r.kernel.org>; Linux
> > ARM <linux-arm-kernel@...ts.infradead.org>; Linux Kernel Mailing List <linux-
> > kernel@...r.kernel.org>; Kishon <kishon@...com>; Andy Shevchenko
> > <andriy.shevchenko@...ux.intel.com>; linux-phy@...ts.infradead.org; Mark
> > Gross <mgross@...ux.intel.com>; kris.pan@...ux.intel.com; Zhou, Furong
> > <furong.zhou@...el.com>; Sangannavar, Mallikarjunappa
> > <mallikarjunappa.sangannavar@...el.com>; Hunter, Adrian
> > <adrian.hunter@...el.com>; Vaidya, Mahesh R
> > <mahesh.r.vaidya@...el.com>; Srikandan, Nandhini
> > <nandhini.srikandan@...el.com>; Demakkanavar, Kenchappa
> > <kenchappa.demakkanavar@...el.com>
> > Subject: Re: [PATCH 2/3] mmc: sdhci-of-arasan: Add intel Thunder Bay SOC
> > support to the arasan eMMC driver
> >
> > On 09-08-21, 05:16, A, Rashmi wrote:
> >
> > > >
> > > > Rashmi, is it safe to apply this separately from the phy driver/dt changes?
> > > > Then I can queue this via my mmc tree, if you like.
> > > No, the phy driver/dt changes must go together with "mmc: sdhci-of-
> > arasan: Add intel Thunder Bay SOC support to the arasan eMMC driver"
> > patch.
> >
> > Why is that?
> >
> > What could happen, emmc driver will complain about phy not found and bail
> > right?
> This is right, but ideally both mmc:phy and mmc: sdhci-of-arasan driver code changes should go together

If patches are well written and can be standalone, we (maintainers)
ideally prefer to queue things on a per subsystem basis, because it's
just easier.

That said, I also noticed that a new compatible string was added,
"intel,thunderbay-sdhci-5.1". This needs to be documented in
Documentation/devicetree/bindings/mmc/arasan,sdhci.yaml, in a separate
patch, preceding $subject patch.

Kind regards
Uffe