linux-kernel - Re: [PATCH] dt-bindings: net: Add the properties for ipq4019 MDIO

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ba6f3daa-7b1c-dd66-f803-c049e1fc3e8a@codeaurora.org>
Date:   Mon, 9 Aug 2021 21:06:43 +0800
From:   Jie Luo <luoj@...eaurora.org>
To:     Andrew Lunn <andrew@...n.ch>
Cc:     agross@...nel.org, bjorn.andersson@...aro.org, davem@...emloft.net,
        kuba@...nel.org, robh+dt@...nel.org, robert.marko@...tura.hr,
        linux-arm-msm@...r.kernel.org, netdev@...r.kernel.org,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
        sricharan@...eaurora.org
Subject: Re: [PATCH] dt-bindings: net: Add the properties for ipq4019 MDIO


On 8/8/2021 11:47 PM, Andrew Lunn wrote:
> On Sun, Aug 08, 2021 at 03:53:28PM +0800, Luo Jie wrote:
>> The new added properties resource "reg" is for configuring
>> ethernet LDO in the IPQ5018 chipset, the property "clocks"
>> is for configuring the MDIO clock source frequency.
>>
>> This patch depends on the following patch:
>> Commit 2b8951cb4670 ("net: mdio: Add the reset function for IPQ MDIO
>> driver")
> Please always make binding patches part of the series containing the
> driver code. We sometimes need to see both to do a proper review.
>
> Add a comment about when the second address range and clock is
> required. Does qcom,ipq5018-mdio require them?
>
> 	  Andrew

Hi Andrew,

yes, the second address range is only required for qcom,ipq5018-mdio 
currently,

will document it in next patch set, and send it with the drive code 
patch, thanks

for the comments and review.