linux-kernel - Re: [PATCH 3/5] mm: migrate: Fix the incorrect function name in comments

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <3794249.AHpkRrbP1t@nvdebian>
Date:   Mon, 9 Aug 2021 23:59:17 +1000
From:   Alistair Popple <apopple@...dia.com>
To:     Baolin Wang <baolin.wang@...ux.alibaba.com>
CC:     <akpm@...ux-foundation.org>, <linux-mm@...ck.org>,
        <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 3/5] mm: migrate: Fix the incorrect function name in comments

Thanks for catching that.

Reviewed-by: Alistair Popple <apopple@...dia.com>

On Friday, 6 August 2021 1:05:58 AM AEST Baolin Wang wrote:
> since commit a98a2f0c8ce1 ("mm/rmap: split migration into its own function"),
> the migration ptes establishment has been split into a separate
> try_to_migrate() function, thus update the related comments.
> 
> Signed-off-by: Baolin Wang <baolin.wang@...ux.alibaba.com>
> ---
>  mm/migrate.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/mm/migrate.c b/mm/migrate.c
> index eeba4c6..6f048a8 100644
> --- a/mm/migrate.c
> +++ b/mm/migrate.c
> @@ -1005,7 +1005,7 @@ static int __unmap_and_move(struct page *page, struct page *newpage,
>  	}
>  
>  	/*
> -	 * By try_to_unmap(), page->mapcount goes down to 0 here. In this case,
> +	 * By try_to_migrate(), page->mapcount goes down to 0 here. In this case,
>  	 * we cannot notice that anon_vma is freed while we migrates a page.
>  	 * This get_anon_vma() delays freeing anon_vma pointer until the end
>  	 * of migration. File cache pages are no problem because of page_lock()
>