linux-kernel - Re: [PATCH] staging: r8188eu: Remove the dependency on ipx network layer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20210809152314.GT1931@kadam>
Date:   Mon, 9 Aug 2021 18:23:14 +0300
From:   Dan Carpenter <dan.carpenter@...cle.com>
To:     Cai Huoqing <caihuoqing@...du.com>
Cc:     gregkh@...uxfoundation.org, Larry.Finger@...inger.net,
        phil@...lpotter.co.uk, fmdefrancesco@...il.com,
        linux-staging@...ts.linux.dev, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: r8188eu: Remove the dependency on ipx network
 layer

On Mon, Aug 09, 2021 at 10:13:39PM +0800, Cai Huoqing wrote:
> +			if (!memcmp(aarp_snap_id, framePtr, 5)) {
> +				framePtr += 5;	/*  eliminate the SNAP header */
>  
> -						DEBUG_INFO("NAT25: Protocol = IPX (Ethernet SNAP)\n");
> -						ipx = (struct ipxhdr *)framePtr;
> -					} else if (!memcmp(aarp_snap_id, framePtr, 5)) {
> -						framePtr += 5;	/*  eliminate the SNAP header */
> +				ea = (struct elapaarp *)framePtr;
> +			} else if (!memcmp(ddp_snap_id, framePtr, 5)) {
> +				framePtr += 5;	/*  eliminate the SNAP header */

To me this looks like we're still parsing an IPX header but we just
deleted the "ipx" variable and any debug output that mentions IPX.
What?

It doesn't look like nat25_handle_frame() is ever called so once you
delete that then you can delete the whole nat25_db_handle() function as
well.  I'd prefer to see that kind of function which deletes whole
functions and the compiler will complain if we delete something unused.

regards,
dan carpenter