linux-kernel - Re: [RFC PATCH v2 05/10] block: Add block device sysfs attribute to set/clear/show LED

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <94f034a0-4c65-48d3-3eaa-a57ceb6a8ce3@gmail.com>
Date:   Mon, 9 Aug 2021 10:44:07 -0500
From:   Ian Pilcher <arequipeno@...il.com>
To:     Jackie Liu <liuyun01@...inos.cn>, linux-block@...r.kernel.org,
        linux-leds@...r.kernel.org
Cc:     axboe@...nel.dk, pavel@....cz, linux-kernel@...r.kernel.org,
        kernelnewbies@...nelnewbies.org
Subject: Re: [RFC PATCH v2 05/10] block: Add block device sysfs attribute to
 set/clear/show LED

On 8/8/21 11:21 PM, Jackie Liu wrote:
>> +// Returns a pointer to the first whitespace character in s (or a pointer to
>> +// the terminating null), which is effectively a pointer to the position *after*
>> +// the last character in the non-whitespace token at the beginning of s.  (s is
>> +// expected to be the result of a previous call to blk_ledtrig_skip_whitespace.)
> 
> These are not linux kernel style comments.

Do you mean kernel-doc comments?  If so, they're not supposed to be, as
the functions are not exported.

>> +static const char *blk_ledtrig_find_whitespace(const char *s)     ^^^^^^

-- 
========================================================================
                  In Soviet Russia, Google searches you!
========================================================================