linux-kernel - Re: [RFC PATCH v2 00/10] Add configurable block device LED triggers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YRKoLBigjbOb/iLa@kroah.com>
Date:   Tue, 10 Aug 2021 18:24:12 +0200
From:   Greg KH <gregkh@...uxfoundation.org>
To:     Ian Pilcher <arequipeno@...il.com>
Cc:     Marek Behún <kabel@...nel.org>, axboe@...nel.dk,
        kernelnewbies@...nelnewbies.org, linux-kernel@...r.kernel.org,
        linux-block@...r.kernel.org, pavel@....cz, pali@...nel.org,
        hch@....de, linux-leds@...r.kernel.org
Subject: Re: [RFC PATCH v2 00/10] Add configurable block device LED triggers

On Tue, Aug 10, 2021 at 10:55:33AM -0500, Ian Pilcher wrote:
> On 8/10/21 9:48 AM, Greg KH wrote:
> > But what about when the device is removed from the system first?  Be
> > careful about that...
> > 
> > Anyway, sure, try those functions, I really do not know, all I
> > originally complained about was those exports which did not need to be
> > exported.
> 
> Sounds good.  I'll work something up.  (I'm actually thinking that
> class_find_device() may be the best way to go, as it grabs a reference
> to the device.)

There should not be anything "odd" about block devices here, just do
whatever all other LED drivers do when referencing a device.

thanks,

greg k-h