linux-kernel - Re: [PATCH v1 1/2] PCI: dwc: Clean up Kconfig dependencies (PCIE_DW

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 10 Aug 2021 17:59:43 +0100
From:   Lorenzo Pieralisi <lorenzo.pieralisi@....com>
To:     Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Cc:     linux-pci@...r.kernel.org, linux-kernel@...r.kernel.org,
        Rob Herring <robh@...nel.org>,
        Krzysztof Wilczyński <kw@...ux.com>,
        Bjorn Helgaas <bhelgaas@...gle.com>
Subject: Re: [PATCH v1 1/2] PCI: dwc: Clean up Kconfig dependencies
 (PCIE_DW_HOST)

On Thu, Aug 05, 2021 at 07:35:38PM +0300, Andy Shevchenko wrote:
> On Thu, Aug 05, 2021 at 02:52:34PM +0100, Lorenzo Pieralisi wrote:
> > On Wed, Jun 23, 2021 at 05:01:02PM +0300, Andy Shevchenko wrote:
> > > First of all, the "depends on" is no-op in the selectable options.
> > > Second, no need to repeat menu dependencies (PCI).
> 
> > Define which specific "depends on" you are referring to.
> 
> I didn't get this because it stands right. It's in general.

Ok, understood what you meant now - I read it as if you were referring
to a specific Kconfig entry that this patch is fixing.

Maybe:

"The "depends on" Kconfig construct is a no-op in options that
are selected and therefore has no effect. Remove it.".


> I can be more specific since it's in align with the code,
> though.
> 
> All the rest I agree with.
> 
> -- 
> With Best Regards,
> Andy Shevchenko
> 
>