lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 10 Aug 2021 08:09:51 +0200 From: Greg Kroah-Hartman <gregkh@...uxfoundation.org> To: Dongliang Mu <mudongliangabcd@...il.com> Cc: Samuel Iglesias Gonsalvez <siglesias@...lia.com>, Jens Taprogge <jens.taprogge@...rogge.org>, Aditya Srivastava <yashsri421@...il.com>, Randy Dunlap <rdunlap@...radead.org>, Lv Yunlong <lyl2019@...l.ustc.edu.cn>, Zhouyang Jia <jiazhouyang09@...il.com>, industrypack-devel@...ts.sourceforge.net, linux-kernel <linux-kernel@...r.kernel.org> Subject: Re: [PATCH v2 2/4] ipack: tpci200: fix memory leak in the tpci200_register On Tue, Aug 10, 2021 at 07:09:15AM +0800, Dongliang Mu wrote: > On Mon, Aug 9, 2021 at 11:32 PM Greg Kroah-Hartman > <gregkh@...uxfoundation.org> wrote: > > > > On Mon, Aug 09, 2021 at 10:30:27PM +0800, Dongliang Mu wrote: > > > The error handling code in tpci200_register does not free interface_regs > > > allocated by ioremap and the current version of error handling code is > > > problematic. > > > > > > Fix this by refactoring the error handling code and free interface_regs > > > when necessary. > > > > > > Reported-by: Dongliang Mu <mudongliangabcd@...il.com> > > > Fixes: 43986798fd50 ("ipack: add error handling for ioremap_nocache") > > > Signed-off-by: Dongliang Mu <mudongliangabcd@...il.com> > > > --- > > > drivers/ipack/carriers/tpci200.c | 24 ++++++++++++++---------- > > > 1 file changed, 14 insertions(+), 10 deletions(-) > > > > Also for stable? > > Yes, it should. Then please resend it, and the other commits that you wish to see go to the stable tree, with the needed "cc: stable..." line in the signed-off-by area. thanks, greg k-h
Powered by blists - more mailing lists