lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 10 Aug 2021 20:42:45 +0200 From: Andrew Lunn <andrew@...n.ch> To: Guenter Roeck <linux@...ck-us.net> Cc: Oleksij Rempel <o.rempel@...gutronix.de>, Heiner Kallweit <hkallweit1@...il.com>, "David S. Miller" <davem@...emloft.net>, Jakub Kicinski <kuba@...nel.org>, Jean Delvare <jdelvare@...e.com>, Pengutronix Kernel Team <kernel@...gutronix.de>, linux-kernel@...r.kernel.org, netdev@...r.kernel.org, Marek Vasut <marex@...x.de>, David Jander <david@...tonic.nl>, linux-hwmon@...r.kernel.org Subject: Re: [PATCH net-next v1] net: phy: nxp-tja11xx: log critical health state > > I'm not so happy abusing the statistic counters like this. Especially > > when we have a better API for temperature and voltage: hwmon. > > > > phy_temp_warn maps to hwmon_temp_max_alarm. phy_temp_high maps to > > either hwmon_temp_crit_alarm or hwmon_temp_emergency_alarm. > > > > The under voltage maps to hwmon_in_lcrit_alarm. > > > > FWIW, the statistics counters in this driver are already abused > (phy_polarity_detect, phy_open_detect, phy_short_detect), so > I am not sure if adding more abuse makes a difference (and/or > if such abuse is common for phy drivers in general). Hi Guenter Abuse is not common in general. I think this is the only driver abusing stats to return flags. At the time those where added, we did not have phy cable test support. Now we do, i would also suggest that the driver makes use of that infrastructure to issue a cable test report. These 'stats' need to stay, since they are ABI, but we should not add more. That is also why i said "Especially when we have a better API". Andrew
Powered by blists - more mailing lists