linux-kernel - Re: [PATCH] openrisc: Fix compiler warnings in setup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 11 Aug 2021 06:13:59 +0900
From:   Stafford Horne <shorne@...il.com>
To:     Randy Dunlap <rdunlap@...radead.org>
Cc:     Guenter Roeck <linux@...ck-us.net>,
        LKML <linux-kernel@...r.kernel.org>,
        Openrisc <openrisc@...ts.librecores.org>,
        kernel test robot <lkp@...el.com>,
        Jonas Bonn <jonas@...thpole.se>,
        Stefan Kristiansson <stefan.kristiansson@...nalahti.fi>,
        Mike Rapoport <rppt@...nel.org>,
        Andrew Morton <akpm@...ux-foundation.org>,
        Kefeng Wang <wangkefeng.wang@...wei.com>,
        Christophe JAILLET <christophe.jaillet@...adoo.fr>
Subject: Re: [PATCH] openrisc: Fix compiler warnings in setup

On Sun, Aug 08, 2021 at 07:28:38PM -0700, Randy Dunlap wrote:
> On 8/8/21 6:31 PM, Guenter Roeck wrote:
> > On Thu, Aug 05, 2021 at 12:00:33PM +0900, Stafford Horne wrote:
> > > This was pointed out with the recent name change of or32_early_setup to
> > > or1k_early_setup.  Investigating the file I found a few other warnings
> > > so cleaning them up here.
> > > 
> > >      arch/openrisc/kernel/setup.c:220:13: warning: no previous prototype for 'or1k_early_setup' [-Wmissing-prototypes]
> > >        220 | void __init or1k_early_setup(void *fdt)
> > > 	  |             ^~~~~~~~~~~~~~~~
> > > 
> > > Fix this the missing or1k_early_setup prototype warning by adding an
> > > asm/setup.h file to define the prototype.
> > > 
> > >      arch/openrisc/kernel/setup.c:246:13: warning: no previous prototype for 'detect_unit_config' [-Wmissing-prototypes]
> > >        246 | void __init detect_unit_config(unsigned long upr, unsigned long mask,
> > > 	  |             ^~~~~~~~~~~~~~~~~~
> > > 
> > > The function detect_unit_config is not used, just remove it.
> > > 
> > >      arch/openrisc/kernel/setup.c:221: warning: Function parameter or member 'fdt' not described in 'or1k_early_setup'
> > > 
> > > Add @fdt docs to the function comment to suppress this warning.
> > > 
> > > Reported-by: kernel test robot <lkp@...el.com>
> > > Signed-off-by: Stafford Horne <shorne@...il.com>
> > 
> > Puzzled. This patch gives me:
> 
> Stafford posted a v2 earlier today:
> https://lore.kernel.org/lkml/20210808135437.3640549-1-shorne@gmail.com/

Yes, thanks for pointing this out.  I found why I missed this in v1,  basically
I failed to miss this using my local build and my CI service on travis seems to
have been stopped.  I have switched to use github actions for CI.

For my local build I will need to watch more carefully.

-Stafford

> > Building openrisc:or1ksim_defconfig ... failed
> > ------------
> > Error log:
> > In file included from ./arch/openrisc/include/asm/page.h:35,
> >                   from ./include/linux/generic-radix-tree.h:39,
> >                   from lib/generic-radix-tree.c:3:
> > ./arch/openrisc/include/asm/setup.h:11:13: error:
> > 		expected '=', ',', ';', 'asm' or '__attribute__' before 'or1k_early_setup'
> >     11 | void __init or1k_early_setup(void *fdt);
> >        |             ^~~~~~~~~~~~~~~~
> > make[1]: *** [scripts/Makefile.build:272: lib/generic-radix-tree.o] Error 1
> > 
> > Bisect log attached for completeness.
> 
> That needs #include <linux/init.h>
> 
> -- 
> ~Randy
>