lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date:   Tue, 10 Aug 2021 13:05:12 +0530
From:   Viresh Kumar <>
To:     Arnd Bergmann <>
Cc:     "Michael S. Tsirkin" <>,
        Viresh Kumar <>,
        Linus Walleij <>,
        Cornelia Huck <>,
        Linux Kernel Mailing List <>,
        Bartosz Golaszewski <>,
        Geert Uytterhoeven <>,
        "open list:GPIO SUBSYSTEM" <>,
        Marc Zyngier <>,
        Thomas Gleixner <>,
        "Enrico Weigelt, metux IT consult" <>,
        Jason Wang <>,
        Stratos Mailing List <>
Subject: Re: [Stratos-dev] [PATCH V4 2/2] gpio: virtio: Add IRQ support

On 09-08-21, 13:19, Arnd Bergmann wrote:
> I don't see anything wrong with this version,


> but let's see what
> Marc thinks. I expect that he can still poke some holes in it, or
> at least find some simplifications.

Right, though I may resend the patches properly first to make it less

> I was slightly surprised at the relation between the disabled and
> masked states, where 'disable' always implies 'mask' and
> 'enable' always implies 'unmask', but I don't actually know how
> those two are actually defined in the irqchip code in Linux, so
> I assume you did this correctly.

I did have a look at the irq-core, but didn't go in real depth. I
rather saw how stuff happens at the driver's end.

- On setup-irq, the core only calls enable() and not unmask().
- On interrupt, the core calls mask(), followed by unmask() (which can
  be delayed for threaded irqs).
- On disable_irq(), the core only calls disable().
- On enable_irq(), the core only calls enable().

And so I ended up at this version :)


Powered by blists - more mailing lists