linux-kernel - Re: [PATCH 2/7] vfio: Export unmap_mapping

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YRI8oP59/+QFL1QD@infradead.org>
Date:   Tue, 10 Aug 2021 10:45:20 +0200
From:   Christoph Hellwig <hch@...radead.org>
To:     Alex Williamson <alex.williamson@...hat.com>
Cc:     linux-kernel@...r.kernel.org, kvm@...r.kernel.org, jgg@...dia.com,
        peterx@...hat.com
Subject: Re: [PATCH 2/7] vfio: Export unmap_mapping_range() wrapper

> +void vfio_device_unmap_mapping_range(struct vfio_device *device,
> +				     loff_t start, loff_t len)
> +{
> +	unmap_mapping_range(device->inode->i_mapping, start, len, true);
> +}
> +EXPORT_SYMBOL_GPL(vfio_device_unmap_mapping_range);

Instead of mirroring the name of unmap_mapping_range maybe give this
a name to document the use case?

> +extern void vfio_device_unmap_mapping_range(struct vfio_device *device,
> +					    loff_t start, loff_t len);

No need for the extern.