linux-kernel - [RFC PATCH v2 0/5] Avoid requesting page from DMA zone when no managed pages

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <20210810094835.13402-1-bhe@redhat.com>
Date:   Tue, 10 Aug 2021 17:48:30 +0800
From:   Baoquan He <bhe@...hat.com>
To:     linux-kernel@...r.kernel.org
Cc:     linux-mm@...ck.org, akpm@...ux-foundation.org, hch@....de,
        robin.murphy@....com, cl@...ux.com, penberg@...nel.org,
        rientjes@...gle.com, iamjoonsoo.kim@....com, vbabka@...e.cz,
        m.szyprowski@...sung.com, rppt@...ux.ibm.com,
        Baoquan He <bhe@...hat.com>
Subject: [RFC PATCH v2 0/5] Avoid requesting page from DMA zone when no managed pages

In some places of the current kernel, it assumes that DMA zone must have
managed pages and try to request pages if CONFIG_ZONE_DMA is enabled.
While this is not always true. E.g in kdump kernel of x86_64, only low 1M
is presented and locked down at very early stage of boot, so that there's
no managed pages at all in DMA zone. This exception will always cause page
allocation failure if page is requested from DMA zone.

E.g in kdump kernel of x86_64, atomic_pool_dma which is created with GFP_DMA
will cause page allocation failure, and dma-kmalloc initialization also
caused page allocation failure.

In this v2 patchset:

* Patch 1, 2 are clean up patches of atomic pool code when read code.
* Patch 3 introduces helper functions to help check if DMA zone with managed
  pages exists.
* Patch 4 is to check if managed DMA zone exists, then create atomic_pool_dma
  if yes.
* Patch 5 is to check if managed DMA zone exists, then create
* dma-kmalloc cache if yes.

This is v1 post:
https://lore.kernel.org/lkml/20210624052010.5676-1-bhe@redhat.com/

v1->v2:
 In v1, I tried to adjust code to allow user to disable atomic pool
 completely with "coherent_pool=0" kernek parameter, then expect to add
 this into kdump kernel to mute the page allocation failure. However,
 later found atomic pool is needed when DMA_DIRECT_REMAP=y or
 mem_encrypt_active() is true, and dma-kmalloc also always caused page
 allocation failure. 

 So in this v2, change to check if managed DMA zone exists. If DMA zone
 has managed pages, we go further to request page from DMA zone to
 initialize. Otherwise, just skip to initialize stuffs which need pages
 from DMA zone.

Baoquan He (5):
  docs: kernel-parameters: Update to reflect the current default size of
    atomic pool
  dma-pool: allow user to disable atomic pool
  mm_zone: add function to check if managed dma zone exists
  dma/pool: create dma atomic pool only if dma zone has mamaged pages
  mm/slub: do not create dma-kmalloc if no managed pages in DMA zone

 .../admin-guide/kernel-parameters.txt         |  5 ++++-
 include/linux/mmzone.h                        | 21 +++++++++++++++++++
 kernel/dma/pool.c                             | 11 ++++++----
 mm/page_alloc.c                               | 11 ++++++++++
 mm/slab_common.c                              |  6 ++++++
 5 files changed, 49 insertions(+), 5 deletions(-)

-- 
2.17.2