lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 10 Aug 2021 18:05:51 +0800 From: Dongliang Mu <mudongliangabcd@...il.com> To: Greg Kroah-Hartman <gregkh@...uxfoundation.org> Cc: Samuel Iglesias Gonsalvez <siglesias@...lia.com>, Jens Taprogge <jens.taprogge@...rogge.org>, Lv Yunlong <lyl2019@...l.ustc.edu.cn>, Randy Dunlap <rdunlap@...radead.org>, Aditya Srivastava <yashsri421@...il.com>, industrypack-devel@...ts.sourceforge.net, linux-kernel <linux-kernel@...r.kernel.org> Subject: Re: [PATCH v3 1/2] ipack: tpci200: fix many double free issues in tpci200_pci_probe On Tue, Aug 10, 2021 at 5:53 PM Greg Kroah-Hartman <gregkh@...uxfoundation.org> wrote: > > On Tue, Aug 10, 2021 at 03:49:21PM +0800, Dongliang Mu wrote: > > The function tpci200_register called by tpci200_install and > > tpci200_unregister called by tpci200_uninstall are in pair. However, > > tpci200_unregister has some cleanup operations not in the > > tpci200_register. So the error handling code of tpci200_pci_probe has > > many different double free issues. > > > > Fix this problem by moving those cleanup operations out of > > tpci200_unregister, into tpci200_pci_remove and reverting > > the previous commit 9272e5d0028d ("ipack/carriers/tpci200: > > Fix a double free in tpci200_pci_probe"). > > > > Reported-by: Dongliang Mu <mudongliangabcd@...il.com> > > Fixes: 9272e5d0028d ("ipack/carriers/tpci200: Fix a double free in tpci200_pci_probe") > > Signed-off-by: Dongliang Mu <mudongliangabcd@...il.com> > > --- > > No cc: stable markings on the patches? > I am sorry that I usually ignore that tag. I have sent a v4 patch with the Cc tag. Dongliang Mu > :( >
Powered by blists - more mailing lists