linux-kernel - Re: [PATCH] staging: r8188eu: Remove some dead files

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 10 Aug 2021 12:19:01 +0200
From:   Greg KH <gregkh@...uxfoundation.org>
To:     Larry Finger <Larry.Finger@...inger.net>
Cc:     phil@...lpotter.co.uk, linux-staging@...ts.linux.dev,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: r8188eu: Remove some dead files

On Mon, Aug 09, 2021 at 04:09:12PM -0500, Larry Finger wrote:
> The porting of the new version included 3 source files that are
> only used for testing of the device. They are not needed here.
> 
> Signed-off-by: Larry Finger <Larry.Finger@...inger.net>
> ---
>  drivers/staging/r8188eu/Makefile            |    3 -
>  drivers/staging/r8188eu/core/rtw_mp.c       |  974 ---------------
>  drivers/staging/r8188eu/core/rtw_mp_ioctl.c | 1170 -------------------
>  drivers/staging/r8188eu/hal/rtl8188e_mp.c   |  798 -------------
>  4 files changed, 2945 deletions(-)
>  delete mode 100644 drivers/staging/r8188eu/core/rtw_mp.c
>  delete mode 100644 drivers/staging/r8188eu/core/rtw_mp_ioctl.c
>  delete mode 100644 drivers/staging/r8188eu/hal/rtl8188e_mp.c

I get the following error with this patch applied:

ERROR: modpost: "rtl8188eu_oid_rt_pro_set_data_rate_hdl" [drivers/staging/r8188eu/r8188eu.ko] undefined!
ERROR: modpost: "rtl8188eu_oid_rt_pro_set_single_carrier_tx_hdl" [drivers/staging/r8188eu/r8188eu.ko] undefined!
ERROR: modpost: "rtl8188eu_oid_rt_pro_stop_test_hdl" [drivers/staging/r8188eu/r8188eu.ko] undefined!
ERROR: modpost: "mp_stop_test" [drivers/staging/r8188eu/r8188eu.ko] undefined!
ERROR: modpost: "MPT_InitializeAdapter" [drivers/staging/r8188eu/r8188eu.ko] undefined!
ERROR: modpost: "Hal_GetThermalMeter" [drivers/staging/r8188eu/r8188eu.ko] undefined!
ERROR: modpost: "Hal_SetThermalMeter" [drivers/staging/r8188eu/r8188eu.ko] undefined!
ERROR: modpost: "MP_PHY_SetRFPathSwitch" [drivers/staging/r8188eu/r8188eu.ko] undefined!
ERROR: modpost: "rtl8188eu_oid_rt_get_efuse_max_size_hdl" [drivers/staging/r8188eu/r8188eu.ko] undefined!
ERROR: modpost: "rtl8188eu_oid_rt_pro_trigger_gpio_hdl" [drivers/staging/r8188eu/r8188eu.ko] undefined!
WARNING: modpost: suppressed 46 unresolved symbol warnings because there were too many)

Are you sure those symbols are not used?

thanks,

greg k-h