linux-kernel - Re: [PATCH] selftests/damon/debugfs_attrs: Add missing execute permission

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YRJisBs9AunccCD4@kroah.com>
Date:   Tue, 10 Aug 2021 13:27:44 +0200
From:   Greg KH <gregkh@...uxfoundation.org>
To:     SeongJae Park <sj38.park@...il.com>
Cc:     akpm@...ux-foundation.org, shuah@...nel.org, linux-mm@...ck.org,
        linux-kselftest@...r.kernel.org, linux-kernel@...r.kernel.org,
        mm-commits@...r.kernel.org, SeongJae Park <sjpark@...zon.de>
Subject: Re: [PATCH] selftests/damon/debugfs_attrs: Add missing execute
 permission

On Tue, Aug 10, 2021 at 11:20:50AM +0000, SeongJae Park wrote:
> From: SeongJae Park <sjpark@...zon.de>
> 
> Commit 04edafbc0c07 ("mm/damon: add user space selftests") of
> linux-mm[1] gives no execute permission to 'debugfs_attrs.sh' file.
> This results in a DAMON selftest failure as below:
> 
>     $ make -C tools/testing/selftests/damon run_tests
>     make: Entering directory '/home/sjpark/linux/tools/testing/selftests/damon'
>     TAP version 13
>     1..1
>     # selftests: damon: debugfs_attrs.sh
>     # Warning: file debugfs_attrs.sh is not executable, correct this.
>     not ok 1 selftests: damon: debugfs_attrs.sh
>     make: Leaving directory '/home/sjpark/linux/tools/testing/selftests/damon'
> 
> To solve the problem, this commit adds the execute permission for
> 'debugfs_attrs.sh' file.
> 
> [1] https://github.com/hnaz/linux-mm/commit/04edafbc0c07
> 
> Signed-off-by: SeongJae Park <sjpark@...zon.de>
> ---
>  tools/testing/selftests/damon/debugfs_attrs.sh | 0
>  1 file changed, 0 insertions(+), 0 deletions(-)
>  mode change 100644 => 100755 tools/testing/selftests/damon/debugfs_attrs.sh
> 
> diff --git a/tools/testing/selftests/damon/debugfs_attrs.sh b/tools/testing/selftests/damon/debugfs_attrs.sh
> old mode 100644
> new mode 100755
> -- 
> 2.17.1
> 

Why not fix the tools to execute the file properly as changing the mode
of a file does not work well with all tools that we use (i.e. patch
files.)

thanks,

greg k-h