lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 10 Aug 2021 15:11:01 +0300 From: Andy Shevchenko <andy.shevchenko@...il.com> To: Len Baker <len.baker@....com> Cc: Jonathan Cameron <Jonathan.Cameron@...wei.com>, Lars-Peter Clausen <lars@...afoo.de>, Kees Cook <keescook@...omium.org>, linux-hardening@...r.kernel.org, linux-iio <linux-iio@...r.kernel.org>, Linux Kernel Mailing List <linux-kernel@...r.kernel.org> Subject: Re: [PATCH v2] drivers/iio: Remove all strcpy() uses in favor of strscpy() On Tue, Aug 10, 2021 at 3:06 PM Andy Shevchenko <andy.shevchenko@...il.com> wrote: > On Mon, Aug 9, 2021 at 7:14 PM Len Baker <len.baker@....com> wrote: > Even if we leave the logic as is, this might be better > > if (orient[0] == '-') > str = devm_kstrdup(dev, orient + 1, GFP_KERNEL); > else if (orient[0] != '0' || orient[1] != '\0') > str = devm_kasprintf(dev, GFP_KERNEL, "-%s", orient); > else > str = devm_kstrdup(dev, orient, GFP_KERNEL); Or these two swapped for better reading else if (orient[0] == '0' **&& orient[1] == '\0') str = devm_kstrdup(dev, orient, GFP_KERNEL); else str = devm_kasprintf(dev, GFP_KERNEL, "-%s", orient); And with a comment added that we negate the result according to the rules: 1) drop leading '-' (minus); 2) leave 0 as is; add leading '-' (minus). > if (!str) > return -ENOMEM; -- With Best Regards, Andy Shevchenko
Powered by blists - more mailing lists