lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
Hash Suite for Android: free password hash cracker in your pocket
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Tue, 10 Aug 2021 14:41:48 +0200
From:   Karsten Graul <>
To:     Vladimir Oltean <>,,
        Jakub Kicinski <>,
        "David S. Miller" <>
Cc:     Andrew Lunn <>,
        Florian Fainelli <>,
        Vivien Didelot <>,
        Vladimir Oltean <>,
        Vadym Kochan <>,
        Taras Chornyi <>,
        Saeed Mahameed <>,
        Leon Romanovsky <>,
        Jiri Pirko <>, Ido Schimmel <>,
        Lars Povlsen <>,
        Steen Hegelund <>,,
        Grygorii Strashko <>,
        Julian Wiedmann <>,
        Heiko Carstens <>,
        Vasily Gorbik <>,
        Christian Borntraeger <>,
        Jianbo Liu <>,
        Vlad Buslov <>,
        Bjarni Jonasson <>,
        Vignesh Raghavendra <>,
        Tobias Waldekranz <>,,,,,, Russell King <>,
        Ido Schimmel <>
Subject: Re: [PATCH v2 net] net: switchdev: zero-initialize struct
 switchdev_notifier_fdb_info emitted by drivers towards the bridge

On 10/08/2021 13:50, Vladimir Oltean wrote:
> The blamed commit a new field to struct switchdev_notifier_fdb_info, but
                  ^^^ added?

> did not make sure that all call paths set it to something valid. For
> example, a switchdev driver may emit a SWITCHDEV_FDB_ADD_TO_BRIDGE
> notifier, and since the 'is_local' flag is not set, it contains junk
> from the stack, so the bridge might interpret those notifications as
> being for local FDB entries when that was not intended.
> To avoid that now and in the future, zero-initialize all
> switchdev_notifier_fdb_info structures created by drivers such that all
> newly added fields to not need to touch drivers again.
> Fixes: 2c4eca3ef716 ("net: bridge: switchdev: include local flag in FDB notifications")
> Reported-by: Ido Schimmel <>
> Signed-off-by: Vladimir Oltean <>
> Reviewed-by: Ido Schimmel <>
> Tested-by: Ido Schimmel <>
> ---
> v1->v2: use an empty struct initializer as opposed to memset, as
>         suggested by Leon Romanovsky

For drivers/s390/net/qeth_l2_main.c :

Reviewed-by: Karsten Graul <>


Powered by blists - more mailing lists