linux-kernel - RE: [PATCH 1/7] x86/amd_nb: Add Aldebaran device to PCI IDs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <BL1PR12MB5286FFF1B2B421A2E37DDF44E8F79@BL1PR12MB5286.namprd12.prod.outlook.com>
Date:   Tue, 10 Aug 2021 12:45:17 +0000
From:   "Chatradhi, Naveen Krishna" <NaveenKrishna.Chatradhi@....com>
To:     "Ghannam, Yazen" <Yazen.Ghannam@....com>
CC:     "linux-edac@...r.kernel.org" <linux-edac@...r.kernel.org>,
        "x86@...nel.org" <x86@...nel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "bp@...en8.de" <bp@...en8.de>,
        "mingo@...hat.com" <mingo@...hat.com>,
        "mchehab@...nel.org" <mchehab@...nel.org>
Subject: RE: [PATCH 1/7] x86/amd_nb: Add Aldebaran device to PCI IDs

[Public]

Hi Yazen

-----Original Message-----
From: Ghannam, Yazen <Yazen.Ghannam@....com> 
Sent: Tuesday, July 20, 2021 12:59 AM
To: Chatradhi, Naveen Krishna <NaveenKrishna.Chatradhi@....com>
Cc: linux-edac@...r.kernel.org; x86@...nel.org; linux-kernel@...r.kernel.org; bp@...en8.de; mingo@...hat.com; mchehab@...nel.org
Subject: Re: [PATCH 1/7] x86/amd_nb: Add Aldebaran device to PCI IDs

On Wed, Jun 30, 2021 at 08:58:22PM +0530, Naveen Krishna Chatradhi wrote:
> From: Muralidhara M K <muralimk@....com>
> 
> Add Aldebaran device to the PCI ID database. Since this device has a 
> configurable PCIe endpoint, it could be used with different drivers.
> 
> Signed-off-by: Muralidhara M K <muralimk@....com>
> Signed-off-by: Naveen Krishna Chatradhi <nchatrad@....com>
> ---
>  include/linux/pci_ids.h | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/include/linux/pci_ids.h b/include/linux/pci_ids.h index 
> 4bac1831de80..d9aae90dfce9 100644
> --- a/include/linux/pci_ids.h
> +++ b/include/linux/pci_ids.h
> @@ -554,6 +554,7 @@
>  #define PCI_DEVICE_ID_AMD_17H_M30H_DF_F3 0x1493  #define 
> PCI_DEVICE_ID_AMD_17H_M60H_DF_F3 0x144b  #define 
> PCI_DEVICE_ID_AMD_17H_M70H_DF_F3 0x1443
> +#define PCI_DEVICE_ID_AMD_ALDEBARAN_DF_F3	0x14d3
>  #define PCI_DEVICE_ID_AMD_19H_DF_F3	0x1653
>  #define PCI_DEVICE_ID_AMD_19H_M50H_DF_F3 0x166d
>  #define PCI_DEVICE_ID_AMD_CNB17H_F3	0x1703
> --

The PCI ID looks right.

But I think this patch can be part of the next patch where this value is first used.
[naveenk:] Squashed this change into the 2nd patch and submitted v2 https://patchwork.kernel.org/project/linux-edac/patch/20210806074350.114614-2-nchatrad@amd.com/

Thanks,
Yazen