lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Tue, 10 Aug 2021 15:12:11 +0200
From:   Thomas Gleixner <>
To:     Mingzhe Yang <>,
        Mingzhe Yang <>
Subject: Re: [PATCH] tasklets: simplify code in tasklet_action_common()

On Fri, Apr 30 2021 at 20:25, Mingzhe Yang wrote:

> Use tasklet_is_disabled() to simplify the code in
> tasklet_action_common.

This changelog is not really helpful. Use a new function does not tell
anything. Neither does it explain why there need to be two new functions
and worse
> +static inline bool tasklet_is_enabled(struct tasklet_struct *t)
> +{
> +	smp_rmb();

why there is suddenly a new undocumented SMP barrier in the code.

> +	return !atomic_read(&t->count);
> +}
> +
> +static inline bool tasklet_is_disabled(struct tasklet_struct *t)
> +{
> +	return !tasklet_is_enabled(t);
> +}
> +

Aside of that there is no point in exposing these functions in a global



Powered by blists - more mailing lists