linux-kernel - Re: [PATCH 09/20] Move Intel SCU IPC of pdx86 to intel directory to increase readability.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YRJ+x7s+xYgzme/w@smile.fi.intel.com>
Date:   Tue, 10 Aug 2021 16:27:35 +0300
From:   Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To:     Kate Hsuan <hpa@...hat.com>
Cc:     Mika Westerberg <mika.westerberg@...ux.intel.com>,
        Hans de Goede <hdegoede@...hat.com>,
        Mark Gross <mgross@...ux.intel.com>,
        Alex Hung <alex.hung@...onical.com>,
        Sujith Thomas <sujith.thomas@...el.com>,
        Rajneesh Bhardwaj <irenic.rajneesh@...il.com>,
        David E Box <david.e.box@...el.com>,
        Zha Qipeng <qipeng.zha@...el.com>,
        Srinivas Pandruvada <srinivas.pandruvada@...ux.intel.com>,
        AceLan Kao <acelan.kao@...onical.com>,
        Jithu Joseph <jithu.joseph@...el.com>,
        Maurice Ma <maurice.ma@...el.com>,
        Dan Carpenter <dan.carpenter@...cle.com>,
        Daniel Scally <djrscally@...il.com>,
        linux-kernel@...r.kernel.org, Dell.Client.Kernel@...l.com,
        platform-driver-x86@...r.kernel.org
Subject: Re: [PATCH 09/20] Move Intel SCU IPC of pdx86 to intel directory to
 increase readability.

On Tue, Aug 10, 2021 at 07:43:42PM +0800, Kate Hsuan wrote:
> Hi Mika,
> 
> Thanks for your suggestion.
> I'll add them to the patches and resend them again.
> 
> Thank you.

Please, do not top post!

> On Tue, Aug 10, 2021 at 6:06 PM Mika Westerberg
> <mika.westerberg@...ux.intel.com> wrote:
> >
> > Hi,
> >
> > No objections, I think this is good idea but..
> >
> > On Tue, Aug 10, 2021 at 05:58:21PM +0800, Kate Hsuan wrote:
> >
> > .. I suggest to add proper commit message here. Many maintainers ignore
> > patches that don't have one.

> > >  rename drivers/platform/x86/{ => intel/scu}/intel_scu_ipc.c (100%)
> > >  rename drivers/platform/x86/{ => intel/scu}/intel_scu_ipcutil.c (100%)
> > >  rename drivers/platform/x86/{ => intel/scu}/intel_scu_pcidrv.c (100%)
> > >  rename drivers/platform/x86/{ => intel/scu}/intel_scu_pltdrv.c (100%)
> > >  rename drivers/platform/x86/{ => intel/scu}/intel_scu_wdt.c (100%)

Besides what Mika said this should follow the example of pmt, like dropping the
intel_scu prefix from the files, but leave it for the module (see Makefile
tricks for the details how to achieve this).

-- 
With Best Regards,
Andy Shevchenko