lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 10 Aug 2021 16:21:01 +0200 From: Thomas Gleixner <tglx@...utronix.de> To: Lee Jones <lee.jones@...aro.org>, lee.jones@...aro.org Cc: linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org, Ming Lei <ming.lei@...hat.com>, Hannes Reinecke <hare@...e.com> Subject: Re: [PATCH 1/1] genirq/cpuhotplug: Bump debugging information print down to KERN_DEBUG On Thu, Jun 17 2021 at 08:31, Lee Jones wrote: > This sort of information is only generally useful when debugging. > > No need to have these sprinkled through the kernel log otherwise. Yes and no. > Cc: Thomas Gleixner <tglx@...utronix.de> > Signed-off-by: Lee Jones <lee.jones@...aro.org> > --- > kernel/irq/cpuhotplug.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/kernel/irq/cpuhotplug.c b/kernel/irq/cpuhotplug.c > index 02236b13b3599..cf8d4f75632e8 100644 > --- a/kernel/irq/cpuhotplug.c > +++ b/kernel/irq/cpuhotplug.c > @@ -42,7 +42,7 @@ static inline bool irq_needs_fixup(struct irq_data *d) > * If this happens then there was a missed IRQ fixup at some > * point. Warn about it and enforce fixup. > */ > - pr_warn("Eff. affinity %*pbl of IRQ %u contains only offline CPUs after offlining CPU %u\n", This one is clearly a warning as this should not happen. See the comments around that. > + pr_debug("Eff. affinity %*pbl of IRQ %u contains only offline CPUs after offlining CPU %u\n", > cpumask_pr_args(m), d->irq, cpu); > return true; > } > @@ -166,7 +166,7 @@ void irq_migrate_all_off_this_cpu(void) > raw_spin_unlock(&desc->lock); > > if (affinity_broken) { > - pr_warn_ratelimited("IRQ %u: no longer affine to CPU%u\n", > + pr_debug_ratelimited("IRQ %u: no longer affine to CPU%u\n", > irq, smp_processor_id()); Maybe, but distro people might have opinions on that. Thanks, tglx
Powered by blists - more mailing lists